skalnik / vim-vroom Goto Github PK

I use this shortcut:

map <Leader>r :VroomRunTestFile<CR>

I updated yesterday and can no longer run the test file in the current buffer. It, instead, runs the whole suite.

Here's an example of what I see in the command window after a spec runs using vroom:

�[32m  I see a message when choosing a low pro hopper�[0m

Finished in 9.52 seconds (files took 0.36624 seconds to load)
�[32m1 example, 0 failures�[0m 

I've looked through the docs, but don't see anything that applies here. How can I get vroom to preserve the same characters I'd see if I ran the spec in my terminal? I'm on Mac OS. I've tried two different fonts w/ Vim just to be sure, but see the same results.

At least for me this morning when I run vroom#RunTestFile() within a cucumber feature I get this error message:

/bin/bash: ./b/./script/cucumber: No such file or directory

I use b as my binstubs directory. This should be calling either ./b/cucumber or, more likely, ./script/cucumber. I'll fix this at some point before too long, but I wanted to register it here.

It would be nice if the current file is autosaved before running tests either with ,r or ,R.

Here is a small snippet on how to execute specs in NeoVim native terminal emulator:

:split | :terminal bundle exec rspec --color

See more about the terminal emulator here: https://www.youtube.com/watch?v=xZbMVj9XSUo

So I propose that this either becomes the "default" when in NeoVim or optional with flag as the others here: https://github.com/skalnik/vim-vroom/blob/master/autoload/vroom.vim#L234-L245

One of the most awesome features of vroom is running the most recent test, even when you aren't in that file. But that doesn't work when you run the most recent nearest test (that is, vroom#RunNearestTest() run from a non-test file).

Here's what happens. Let's say you ran vroom#RunNearestTest() from spec/some_spec.rb:10. Then you navigate to lib/some.rb and put your cursor on line 15. When you run vroom#RunNearestTest() you will run the spec nearest to line 15 (you'll run rspec spec/some_spec:15).

The problem is that the definition of s:RunNearestTest in autoload/vroom.vim (https://github.com/skalnik/vim-vroom/blob/master/autoload/vroom.vim#L113-118) we set the line number from the current file without checking to see if that is a test file.

I think we can fix it by borrowing from the s:RunTestFile method above it and wrap the code in a conditional. There is probably an elegant way to do this. But I'm unable to write it up right now (in large part because I don't have a setup to test it). I could probably get to it next week, but I make no promises. Either way, I'm registering it here for future reference. 😃

We should have some docs around #32.

@ericboehs mentioned he may add them

Is there a specific reason, why :VroomRunTestFile respects the g:vroom_clear_screen setting, while :VroomRunLastTest does not?

My expectation as a user would be, that both respect the setting.

If there's no specific reason and you agree, that both commands should respect the setting and clear the screen before running, then I'd commit a PR.

And: Thanks for this very useful and well working (for me) software. It saved me a lot of time and hackery and frustration. Thank you! ✨

When using vundle, after initially installing vim-vroom, future runs of :BundleInstall raise an error:

When trying to run vroom - it doesn't seem to take into account my .ruby-version file, instead trying to use system ruby.

When I run r on a project, without zeus running, it does append the --no-color to the command (bundle exec rpsec --no-color..), so the output isn't messed up with ansi color codes.

But that switch is missing when zeus is running (and because I have "--color" in .rspec) the output is cumbersome to read.

Thanks, great plugin

I have vim-vroom installed, but after calling :VroomRunTestFile, nothing happens :/, i don't even get an error. I have tried changing g:vroom_test_unit_command to:

• 'bin/rake test '
• 'rake test '
• 'bundle exec ake test '
• 'bin/rake test TEST='
• 'rake test TEST='

But none of them throws an error. Any idea how can I continue troubleshoot this?

I think the function CheckForSpecHelper was added but never actually called, making vroom_detect_spec_helper option completely useless.

Hey,
Thanks for the add-on, I really like it.

I have small questions, I started to move slowly to NeoVim and I encounter strange warning when I run tests with vim-vroom and vim dispatch inside tmux session. I'm receiving this:

Unknown option argument: "--servername"

However everything seems to be working fine as tests are executed properly. Is this flag needed for this plugin?

Hi,

I would like to modify vim-room to optionally integrate with vimux. Basically, when I'm using tmux I want to run tests from vim but have them displayed in the tmux pane below. Vimux makes that easy, but vim-room is a superior testing framework and I want to continue using it. Is it ok for you if I fork and add this functionality?

There are too many g:isUsingX options for things like zeus and spring (and others?). I worry about having too many options to configure. Could we have a g:testPreloader variable that stores a string, and then a s:setPreloader function that does an necessary checks and then inserts the proper command? Would that simplify things?

Thoughts on a value for g:vroom_use_binstubs (maybe 2?) that uses binstubs if the appropriate one exists, but if not, falls back to default behavior?

If you agree, I could try to hack something together :)

/Users/alindeman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/test/unit.rb:49:in `process_args': invalid option: --color (OptionParser::InvalidOption)

Disabling color causes it to whine about --no-color

I try to write as many tests as possible that don't use Rails. But sometimes you want integration tests that do use Rails. In those cases I like to call my tests manually (no Guard, for example), but use Spork to speed up the TDD loop. Now that I'm hooked on Vroom I'm not loving having to switch over to a new terminal tab to run rspec spec/integration/whatever_spec.rb --drb. I think it would be nice to have a function I could write a mapping for that basically does what vroom#RunTestFile() and vroom#RunNearestTest() do but appends the --drb flag. I can do this (well, it will require some refactoring, so I should say I can write a version of this that you might want to revise :)).

Is this something you'd support/be interested in, or is it outside of the scope of vroom (or maybe even the wrong place to call this option)?

I use minitest-reporters gem and it displays a nice output (with colors) when I run rake test from console.
When I run my tests inside vim with vim-vroom plugin colors are not displayed. Is there any configuration I can set to format test output?

Current vroom support zeus for rspec nicely, but still do not use zeus for cucumber test

Since turnip features also use the .feature extension, vroom tries running them with cucumber. The convention for cucumber is to put features in ./features while turnip features go in ./spec/features. This convention should be sufficient to distinguish between test runners here.

I'm trying to use "rake test TEST=" as the test unit command. I added:

let g:vroom_test_unit_command = "rake test TEST="

But now I get:

/Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib/rake/rake_test_loader.rb:15:in `require': cannot load such file -- /Users/bhilkert/Dropbox/code/perform (LoadError)
    from /Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib/rake/rake_test_loader.rb:15:in `block in <main>'
    from /Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib/rake/rake_test_loader.rb:4:in `select'
    from /Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -I"lib:test" -I"/Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib" "/Users/bhilkert/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/rake-10.2.2/lib/rake/rake_test_loader.rb" "" ]

Tasks: TOP => minitest:single
(See full trace by running task with --trace)

It seems to still be running the ruby test unit runner. Am i missing something?

See vim-rspec feature:

https://github.com/thoughtbot/vim-rspec/blob/master/plugin/rspec.vim#L39

I am new to vim script so I presume you would go faster than me. If you have no time or don't see the value of this feature, I'll try other plugins and updates the isssue if I find something. If I don't find any alternative, I'll try to add it to vroom.

To speed things further, could this plugin look for spec_helper in the spec file then make a decision on whether to run inside bundler or not?

I am thinking of http://cl.ly/FkGu for inspiration.

I'm using Test::Unit + shoulda and when I hit R within a single test, I'm getting this error:

:!bundle exec ruby -Itest test/unit/revenue_change_test.rb:9
ruby: No such file or directory -- test/unit/revenue_change_test.rb:9 (LoadError)

I believe in Test::Unit you need to give it the method name or a regex to match it.

1st link in README to documentation is broken.

It says at the bottom:

-- More  SPACE/d/j: screen/page/line down, b/u/k: up, q: quit

but whatever I've tried it doesn't works...

For isolated Rails tests, it's sometimes nice to run without bundle exec. If using rvm gemsets or similar, bundle exec is not necessary and adds unnecessary startup time.

It would be nice if vim-vroom allowed a configuration option to disable using bundle exec in all cases.

Totally just a nice to have, of course! Thanks for your work on this.

Just a WIP todo list of stuff that'd be handy to have before we can 🚢 a 2.0

• Some tests
• Overhauled options parser
• A few more sane defaults?

/cc @alindeman @charlietanksley