Comments (5)
@Keagel @salisshuaibu11 after reviewing the source directly I see the issue here. It looks like the SVG was abstracted to a template literal to cleanup the template a bit.
The class={classesControlCaret}
carried through, even though that should have been removed. You can see the new home for those styles is now applied to a wrapping div elements here:
If for some reason you need access to to style the SVG element itself, this is already possible using this Tailwind syntax:
https://www.skeleton.dev/docs/styling#tailwinds-arbitrary-variants
For example:
<AccordionItem classesControlCaret="[&>svg]:fill-red-500">...</AccordionItem>
Alternatively, the caret region is actually a Svelte slot, which means you can replace the open and close icons with custom SVGs. Then adjust the styles as desired.
https://www.skeleton.dev/components/accordions#custom-icons
That said, I'll go ahead and submit a quick change to remove the duplicate class on the SVG template literal now to close this out though. This should help avoid further confusion in the future. Expect this to go out as part of the next release of Skeleton v2.
from skeleton.
@salisshuaibu11 thanks for diving into this. I'd say leave this one to me. I need to dive in an review the full context before I can provide an answer to how we should approach this. And by that time I can probably implement the adjustment directly just as quickly. I'll take all information above into consideration when I get to that point though!
from skeleton.
@endigo9740 i would like to take this
from skeleton.
@endigo9740, I've reviewed the svgCaretIcon. Despite correcting the interpolation, the class remains undefined even though "classesControlCaret" is present. The solution was to embed the SVG directly into the HTML without passing it as a variable and utilizing the @html special tags.
Considering that we're utilizing the "svgCaretIcon" constant in three different locations, is there a more optimal solution available?
from skeleton.
@endigo9740, incorporating the dollar sign label resolved the issue, although I'm uncertain if this is the most efficient approach.
$: svgCaretIcon = svg
from skeleton.
Related Issues (20)
- ListBox + Popup on a Modal HOT 5
- Tailwind v4 Oxide <--> Skeleton v3 HOT 6
- Chore: Add `environment info` request on bug tickets
- Standardize Dev Tooling and CI Pipelines HOT 15
- Some v2 doc images are not displaying HOT 1
- Integration: Data Visualization
- v3 Custom Theme Doc Errors
- v3 Tailwind > Gradients CSS button has broken link
- Review "RestProps" spread method for arbitrary attributes HOT 2
- v3 Switch Component - Quick Patch
- computed styles not being applied HOT 3
- Repeated word in Docs HOT 1
- Audio/video components
- Svelte v5 RC: InputChip component produces errors HOT 9
- v3 React AppBar does not follow export conventions HOT 1
- v3 - consistency -D and --save-dev HOT 6
- TreeView - Custom Icons. HOT 1
- Carousel seems broken on doc page HOT 1
- Refactor React components to fall more inline with existing React libraries HOT 4
- RFC: Remove return types from React components
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skeleton.