Giter VIP home page Giter VIP logo

Comments (3)

skx avatar skx commented on May 26, 2024 1

Updated to force the user to specify the DB-type and DSN-string.

Confirmed it works on MySQL & SQLite (memory and on-disk).

from marionette.

alexwhitman avatar alexwhitman commented on May 26, 2024

A mysql module feels a bit specific. It might be better to have a sql module which has an engine attribute to define the database type

sql {
    engine => "mysql",
    username => "root",
    password => "secret",
    database => "users",
    sql => "SELECT COUNT(id) FROM wp_users WHERE login LIKE \"steve%\"",
}

This way it allows for adding PostgreSQL, SQLite, Oracle, MSSQL etc without having modules for each.

Another thought would be to allow the SQL to be defined in a file sql_file => "/path/to/file.sql" which could contain multiple statements to run.

Something else to think about may be how to deal with SELECT statements vs INSERT/UPDATE/DELETE and if results could/should be useable. There may be cases where some SQL should be run if/unless another SQL query returns a result/value.

from marionette.

skx avatar skx commented on May 26, 2024

Good comment, and definitely agreed that engine-agnostic would be better.

For any initial attempt I think it would be sufficient to run some SQL. I'd assume that such an action would need to be triggered if it wasn't safe to run multiple times.

from marionette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.