skylarscaling / cg-openshift-test-deploy Goto Github PK

Currently, the Ansible playbook completes before the Service Mesh is fully deployed. It would be nice for the playbook to wait for the Service Mesh to fully deploy.

Here are some code examples showing how to wait for deployments to complete:
https://github.com/noseka1/ansible-base/blob/master/roles/openshift_ocs/tasks/deploy_ocs.yml

Currently, in the ServiceMeshSub.yaml the Kubernetes manifests are in-lined. Can we instead put them into separate files? After that, the Ansible script can use lookup like this:

- name: Create Service Mesh Subscription
  k8s:
    definition: "{{ lookup('template', 'servicemeshoperator-subscription.yaml') }}"

It's a convention to use snake case for the Ansible scripts. For example:
AnsibleDeploy.yaml -> ansible_deploy.yaml
BookinfoDeploy.yaml -> bookinfo_deploy.yaml