Giter VIP home page Giter VIP logo

deno-github-functions's People

Contributors

cchensh avatar filmaj avatar github-actions[bot] avatar hello-ashleyintech avatar mcodik avatar misscoded avatar mwbrooks avatar seratch avatar srajiang avatar stevengill avatar vegeris avatar williambergamin avatar wongjas avatar zimeg avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

seratch williambergamin dafaulkensllc primenumber-dev zimeg mac2flip julian-englert leoniliana

deno-github-functions's Issues

Workflow fails to create a GitHub issue

When I deploy this app to Slack infra, and kick off the link trigger, fill out the form, no issue is created. In slack activity logs I see:

Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:27:38 [info] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Execution started for workflow 'Create new issue'
2023-04-10 16:27:38 [info] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Executing workflow step 1 of 3
2023-04-10 16:27:38 [info] [Fn010N] (Trace=Tr052XUJK82D) Function execution started for builtin function 'Open a form'
2023-04-10 16:27:47 [info] [Fn010N] (Trace=Tr052XUJK82D) Function execution completed for function 'Open a form'
2023-04-10 16:27:48 [info] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Execution completed for workflow step 'Open a form'
Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:27:49 [error] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Execution failed for workflow 'Create new issue'
	parameter_validation_failed - Validation for parameter `githubIssue` failed: missing_required_value
Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:28:50 [error] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Execution failed for workflow 'Create new issue'
	parameter_validation_failed - Validation for parameter `githubIssue` failed: missing_required_value
Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:29:12 [error] [Wf052MJEG6QL] (Trace=Tr052XU78T4H) Execution failed for workflow 'Create new issue'
	parameter_validation_failed - Validation for parameter `githubIssue` failed: missing_required_value
Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:30:50 [error] [Wf052MJEG6QL] (Trace=Tr052XUJK82D) Execution failed for workflow 'Create new issue'
	parameter_validation_failed - Validation for parameter `githubIssue` failed: missing_required_value
Token fetch succeeded for user 'U02AEHE4KG9' on workspace 'T029V6468RL' for app 'A052K0SBGBV' and provider 'github'
2023-04-10 16:32:13 [error] [Wf052MJEG6QL] (Trace=Tr052XU78T4H) Execution failed for workflow 'Create new issue'
	parameter_validation_failed - Validation for parameter `githubIssue` failed: missing_required_value

This same behaviour is reproducible in local apps, too.

Cannot run app locally

Seems like a manifest validation issue... but interestingly, I can deploy the app to Slack infra just fine.

➜ hermes run
? Choose a local environment filboxworkspace T029V6468RL A04MWCC40DN
Updating local app install for workspace "Filbox"
Check /Users/fmaj/.slack/logs/slack-debug-20230410.log for full error logs

🚫 Error: The provided manifest file does not validate against schema. Consult the additional errors field to locate specific issues (invalid_manifest)

Error Details:

1: Workflow function `create_new_issue_workflow` step `1` param `githubAccessTokenId` does not contain a valid provider key` (provider_not_found_wf_function_step)
Source: /workflows/create_new_issue_workflow/steps/1


The above errors were returned by the following Slack API method: /api/apps.manifest.validate

Create issue function does not work as a step within a workflow created through Workflow Builder

When adding the Github create issue function as a step within a workflow created through the Workflow Builder, only the url field is displayed since the other required fields are wrapped in the githubIssue object. This also prevents the form from being sent with just the url field, leaving the user confused.

I think that one fix would be to remove this object and then just use the fields without the wrapping.

Screen.Recording.2023-08-08.at.14.15.37.mov

Improve documentation for external authentication in a deployed environment

A section or additional wording should be added to the README to suggest best practices when collaborating on a deployed app when using external auth providers.

This section might suggest adding tokens to local apps individually (on a per-developer basis) while relying on a shared token for the deploy environment.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.