slartibartfass2 / dunetowerdefense Goto Github PK

Currently we use reflection to load a test config file.
Instead create a second constructor which takes the config file path and annotate it with testOnly.

Refactor code which has a too high complexity according to SonarLint.

The equals methods only check for uuid equalty which shouldn't be the case.
It was implemented so that the controller classes can map an entity to a game model but this can be replaced by mapping the uuid directoy to the game model.

For easier testing and implementation of configurations replace properties file with json file which can be parsed to Configuration object.

Probably it would be good to split the config file into several config files each for a component of the game e.g. a sound tower config file.
On the other hand this would complicate loading the files as one has to load a file for each component instead a single one.

So having one file with different config objects is probably the best way.

A starting point could be:

{
  "soundTowerConfig": {
    "range": 10,
    "reloadTime": 1000,
    ...
  },
  ...
}

The soundTowerConfig object could then be passed to each soundTower which then can read and adapt those values.

A schema should be created as well to verify the correctness of the file.

Remove unnecessary null argument tests
Replace random object creation with specific test cases

Make Controller classes Optional arguments to reduce duplicated constructors.

The user should be able to save the game and load it again.

Add tests for existing functionality to increase code coverage