vmodes minor cleaning up and improvement about croco HOT 4 CLOSED

Since you opened this issue, I have a question / suggestion on load_vmodes:

• persistis passed to Vmodes as is because the dataset is subsequently re-assigned? Otherwise, when persisting an object, even when not using it or triggering its computation explicitly, dask can launch the corresponding task if it's doing nothing, right?
• this line is False, I think:
  

  croco/crocosi/vmodes.py

  Line 519 in c16668c

  ds_proj = projections.persist()

  
  should read projections = projections.persist()

from croco.

* Right now it is unclear whether this horizontal interpolation may be performed within the call to `project`or not.

I did not intent to have horizontal projections performed inside Vmodes. Either we should add this functionality in the class and methods -- if we think it is necessary, either we make it very clear in the API and example notebook. As far as I'm concerned, I don't need it (because I do mostly weird projections that mix different grids anyway)

from croco.

• doc and tests for horizontal grid interpolations
• update vmodes.ipynb
• ds_proj = projections.persist()corrected

from croco.

relevant PR is #25

from croco.