Giter VIP home page Giter VIP logo

is-is-odd's People

Contributors

anematode avatar jonta avatar slmjkdbtl avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

is-is-odd's Issues

Security vulnerability: Use strict equality operator

The code currently uses the abstract equality operator ==, meaning that a stringified version of the isOdd function will incorrectly return true.

Example:

const isOdd = require('is-odd');
const isIsOdd = require('is-is-odd');

console.log(isIsOdd(isOdd.toString())); // -> true

Rewrite in Rust

We seem to have reached a working version of this project that a lot of customers can enjoy on a daily basis without any major problems or performance issues, that's why I propose to rewrite this project in Rust.

Please let me support my proposal with the following arguments:

  • According to this Medium article, JavaScript is a dead language and we should switch to a modern language to ensure the security and further usability of our project.
  • While single core performance is barely increasing, modern systems get more and more CPU cores. Rust enables us to parallelize the key features of our library by preventing race conditions and supporting async programming.
  • Rust is an unmanaged language, meaning that it has no garbage collector that can at any time interrupt your program. This would allow our project to be used by performance critical and realtime applications.
  • Google also sometimes uses Rust.

Let me know your opinions :)

Support other versions of is-odd

My project directly depends on an older version of is-odd for legacy reasons but even the earliest release of is-is-odd seems to only check against the latest version that matches its own dependency (at time of install?) resulting in a false negative.

image

image

Minimal reproducible example:

mkdir is-is-odd-example
cd is-is-odd-example
npm install is-odd@2 is-is-odd
node -e "console.log(require('is-is-odd')(require('is-odd')))"
# outputs false

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.