slunak / pushover-php Goto Github PK

We're using Pushover and this great wrapper for our application to notify users about upcoming events. For easy handling we're using the Pushover Subscription API, so instead of user keys, we have subscription keys. Other as stated in the Pushover documentation, the response seems to not contain the licenses for the user. This leads to an error:

Undefined property: stdClass::$licenses
in serhiy/pushover/src/Client/Response/UserGroupValidationResponse.php in line 103

Steps to reproduce:

1.) Acquire subscription key via Pushover Subscription API
2.) Try to validate using Serhiy\Pushover\Api\UserGroupValidation\Validation

$application = new Application($appId);
$validation = new Validation($application);
$recipient = new Recipient($subscriptionKey);

$response = $validation->validate($recipient);

The last line throws this message

Potential fix:

Check if response contains licenses data prior to accessing it. Since PHP 7 it is possible to use null-coalesence operator ??.
Replace line 103 as follows:

$this->setLicenses($decodedCurlResponse->licenses ?? []);

Thank you for your great work!

Best regards,
Sebastian

Travis is missing a library when building PHP 8.2 environment. At the moment I implemented a workaround I described here:

https://travis-ci.community/t/php-8-2-support/13401

I would need to come back to this later when Travis properly supports 8.2.

I will be dropping support for PHP versions 7.1, 7.2 and 7.3, making version 7.4 a minimal required version to run this library. The library version number will be incremented from 1.2.0 to 2.0.0. I will then stop supporting the version 1.2.0.

Update: After dropping mentioned PHP versions, the library minor version will be incremented, e.g. 1.3.0.

Curl Request Failed error is thrown multiple times when used in a server.