smari / voting Goto Github PK

A simulator for voting systems.

Python 77.21% CSS 0.81% HTML 0.17% JavaScript 4.91% Vue 16.81% Dockerfile 0.09%

voting's Issues

ValueError: math domain error

I got this error in one of my simulations but couldn't grab the values from the traceback. I'll start logging the output and report back.

Traceback (most recent call last):
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/levy/code/voting/venv/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/levy/code/voting/backend/web.py", line 194, in check_simulation
    "results": simulation.get_results_dict()
  File "/home/levy/code/voting/backend/simulate.py", line 526, in get_results_dict
    self.analysis()
  File "/home/levy/code/voting/backend/simulate.py", line 505, in analysis
    self.analyze_list(ruleset, measure, c, p)
  File "/home/levy/code/voting/backend/simulate.py", line 280, in analyze_list
    std = sqrt(var)
ValueError: math domain error

Uploading vote table from xlsx file - AttributeError: 'SpooledTemporaryFile' object has no attribute 'seekable'

I was running some simulations recently, and discovered that the file upload had broken.
I do not remember when I last tried to upload a vote table xlsx file, so I do not know exactly when this became a problem,
but at least it was most definitely not a problem when I was working on the file upload feature last year.

The issue is when uploading votes from an xlsx file, and loading the filestream into a workbook using openpyxl.
The filestream is of type SpooledTemporaryFile, but openpyxl seems to expect it to implement BufferedIOBase or something like that (I'm no expert in these IO implementations)

Here's the relevant code:

@app.route('/api/votes/upload/', methods=['POST'])
def upload_votes():
    ...
    f = request.files['file']
    res = util.load_votes_from_stream(f.stream, f.filename)
    ...

def load_votes_from_stream(stream, filename):
    rd = []
    if filename.endswith(".csv"):
        ...
    elif filename.endswith(".xlsx"):
        book = openpyxl.load_workbook(stream)
        ...
    else:
        return None, None, None

I found this related werkzeug issue from two years ago.
pallets/werkzeug#1344

It seems to have been resolved, so I tried just updating werkzeug and flask, as well as openpyxl.
But that did not solve this, so I added a couple of lines to fix this, although I'm not satisfied with that solution:

if not hasattr(stream, "seekable") and hasattr(stream, "_file"):
    stream.seekable = stream._file.seekable

See PR: #94

Add support for candidate lists

Candidate lists should include name, age, party, seat in party-list, photo URL, gender, etc.

This helps with showing results in a fun and interactive way.

`constituencies` not part of /api/capabilities/ response

Hey all,

Fixed a few issues to get the frontend working, see #10

The bakend doesn´t seem to return the constituency array required for the frontend to render VotesTable.

The initial state being set: https://github.com/smari/voting/blob/master/voting/static/js/ui.js#L362
constituencies state property not being updated on GET: https://github.com/smari/voting/blob/master/voting/static/js/ui.js#L378
An attempt to iterate over the constituency array (which is empty since it´s not being updated on GET -> setState()): https://github.com/smari/voting/blob/master/voting/static/js/ui.js#L115

The setPreset func asks for a constituency property which is not part of the response:

https://github.com/smari/voting/blob/master/voting/static/js/ui.js#L584

Output from /api/capabilities/

{
  "key": 1,
  "rules": {},
  "election_rules": {
    "primary_divider": "dhondt",
    "adjustment_divider": "dhondt",
    "adjustment_threshold": 0.05,
    "adjustment_method": "icelandic-law",
    "constituency_seats": [
      7,
      9,
      9,
      11,
      9,
      9
    ],
    "constituency_adjustment_seats": [
      1,
      1,
      1,
      2,
      2,
      2
    ],
    "constituency_names": [
      "Norðvestur",
      "Norðaustur",
      "Suður",
      "Suðvestur",
      "Reykjavík suður",
      "Reykjavík norður"
    ],
    "parties": [
      "A",
      "B",
      "D",
      "G",
      "H",
      "I",
      "J",
      "K",
      "L",
      "M",
      "R",
      "S",
      "T",
      "V",
      "Þ"
    ],
    "votes": [
      [
        792,
        6104,
        4282,
        208,
        0,
        161,
        774,
        0,
        251,
        326,
        0,
        2122,
        328,
        1470,
        537
      ],
      [
        1537,
        8173,
        5327,
        296,
        0,
        241,
        306,
        0,
        313,
        0,
        0,
        2505,
        460,
        3733,
        716
      ],
      [
        1202,
        9265,
        7596,
        703,
        0,
        786,
        412,
        0,
        431,
        0,
        0,
        2734,
        904,
        1582,
        1269
      ],
      [
        4687,
        10944,
        15608,
        925,
        0,
        1838,
        188,
        0,
        1241,
        0,
        0,
        6932,
        1927,
        3995,
        2541
      ],
      [
        3790,
        5931,
        9466,
        575,
        55,
        1394,
        161,
        222,
        1025,
        0,
        54,
        5007,
        1163,
        4279,
        2179
      ],
      [
        3576,
        5759,
        8187,
        556,
        71,
        1289,
        181,
        0,
        1398,
        0,
        64,
        4996,
        1073,
        5493,
        2407
      ]
    ],
    "simulate": false,
    "debug": false,
    "show_entropy": false,
    "output": "simple"
  },
  "simulation_rules": {
    "simulate": false,
    "simulation_count": 100,
    "simulation_variate": "beta"
  },
  "presets": [
    {
      "name": "Icelandic Parliament election 2013",
      "action": "election",
      "election_rules": {
        "primary_divider": "dhondt",
        "adjustment_divider": "dhondt",
        "adjustment_threshold": 0.05,
        "adjustment_method": "icelandic-law",
        "constituency_seats": [
          7,
          9,
          9,
          11,
          9,
          9
        ],
        "constituency_adjustment_seats": [
          1,
          1,
          1,
          2,
          2,
          2
        ],
        "constituency_names": [
          "Norðvestur",
          "Norðaustur",
          "Suður",
          "Suðvestur",
          "Reykjavík suður",
          "Reykjavík norður"
        ],
        "parties": [
          "A",
          "B",
          "D",
          "G",
          "H",
          "I",
          "J",
          "K",
          "L",
          "M",
          "R",
          "S",
          "T",
          "V",
          "Þ"
        ],
        "votes": [
          [
            792,
            6104,
            4282,
            208,
            0,
            161,
            774,
            0,
            251,
            326,
            0,
            2122,
            328,
            1470,
            537
          ],
          [
            1537,
            8173,
            5327,
            296,
            0,
            241,
            306,
            0,
            313,
            0,
            0,
            2505,
            460,
            3733,
            716
          ],
          [
            1202,
            9265,
            7596,
            703,
            0,
            786,
            412,
            0,
            431,
            0,
            0,
            2734,
            904,
            1582,
            1269
          ],
          [
            4687,
            10944,
            15608,
            925,
            0,
            1838,
            188,
            0,
            1241,
            0,
            0,
            6932,
            1927,
            3995,
            2541
          ],
          [
            3790,
            5931,
            9466,
            575,
            55,
            1394,
            161,
            222,
            1025,
            0,
            54,
            5007,
            1163,
            4279,
            2179
          ],
          [
            3576,
            5759,
            8187,
            556,
            71,
            1289,
            181,
            0,
            1398,
            0,
            64,
            4996,
            1073,
            5493,
            2407
          ]
        ],
        "simulate": false,
        "debug": false,
        "show_entropy": false,
        "output": "simple"
      }
    }
  ],
  "capabilities": {
    "adjustment_methods": {
      "alternating-scaling": "Alternating-Scaling Method",
      "icelandic-law": "Icelandic law 24/2000 (Kosningar til Alþingis)",
      "monge": "Monge algorithm",
      "relative-inferiority": "Relative Inferiority Method",
      "relative-superiority": "Relative Superiority Method"
    },
    "divider_rules": {
      "dhondt": "D'Hondt's method",
      "sainte-lague": "Sainte-Laguë method",
      "swedish": "Nordic Sainte-Laguë variant"
    }
  },
  "capabilities_loaded": true,
  "votes": []
}

Comparative error estimation

Count number of seat-flips occurring in a method as delta from optimal (maximum entropy)

Fuzz votes

Add votes, one-by-one, in support of a party list in a district.

If a new vote doesn't gain that party list a seat, report any change in results.
Even if a new vote does gain that party list a seat, do report if the result change is greater than just moving a seat in the relevant constituency between parties and moving one seat in the opposite direction in another constituency.

Mæliaðferð: fjöldi víxlanna milli kjördæma með jöfnunarmönnum samanborið við kjördæmi án jöfnunarmanna

Þetta er góð visualization aðferð og/eða mæliaðferð: að bera saman fjölda víxlanna milli kjördæma með jöfnunarmönnum samanborið við það hvernig það væri ef kjördæmin hefðu enga jöfnunarmenn (en jafn mörg sæti í heild).

Finish Relative Infreriority Algorithm

Þorkell Helgason's Relative Inferiority Algorithm.

Resolve ties

Balinski axiom violation detection

Fix parameters on Monge algorithm

Parameters are wrong at the moment.

Age distribution

Generate random initial votes

Draw percentages for each party in each district from a beta distribution with historical mean and variance. Then normalize the percentages to add up to 100%.

Samanburðarmæling

Að bera saman óreiðu mismunandi aðferða í mismunandi kosningum, sem hlutfall af bestu lausn (Balinski).

CORS config

Since we decoupled the frontend from the backend we need to consider CORS headers configs. Running web servers is not my expertise so it would be great to hear peoples general opinions on this when dealing with frontend applications making XMLHttpRequests (or Fetch) directly to a service.

I guess this is also somewhat related to authentication of the app in general but another topic.

So instead of same-origin we could:

Whitelist IPs?
Allow all?

smari / voting Goto Github PK

voting's Issues

Recommend Projects

Recommend Topics

Recommend Org