smartrent / credo_binary_patterns Goto Github PK

When implementing binary patterns in Grizzly, I came across the following patterns and their suggested fixes.

size(byte_size)-signed-unit(8) -> signed-byte_size-unit(8)
size(size)-signed-unit(8) -> signed-size-unit(8)
integer-unsigned-unit(8)-size(size) -> size-unit(8)

All of which result in a variant of the following syntax error "bitstring specifier "" does not exist and is being expanded to "()", please use parentheses to remove the ambiguity"

Needs to be corrected to

integer-signed-unit(8)-size(size) -> signed-size(size)-unit(8)
integer-unsigned-unit(8)-size(size) -> integer-size(size)-unit(8)
size(byte_size)-signed-unit(8) -> signed-size(byte_size)-unit(8)

Thank you, @doawoo for helping me figure out what was going on here.

For example, recommend x::little-32 for instances of x::little-integer-size(32).