smileisak / docker-images Goto Github PK

Good evening!

Is alpine:edge needed here?

Per https://wiki.alpinelinux.org/wiki/Edge
"End users should not use "edge" as their main day-to-day workstation or as productive system."
As this image is part of the helm charts stability may be important.
alpine:3.7 or alpine:latest provide redis 4.0.6-r0 out of the box.

Thanks and best regards
Marc

Usage of kubectl inside the container does not pass any -n argument, depending on deployment to the default namespace.

Allow this to be overridden by reading the its own namespace, or fron environment variables.

Hi there,

I've got a chart which is based off of the stable/redis-ha chart, which uses the image built from this repo, I believe. I'd like to pass in arguments to the redis-server (--maxmemory 256mb, --maxmemory-policy noeviction, etc.).

Is there a reason why run.sh doesn't pass along whatever args happen to be passed in via $@?

During startup, the image issues the following warning:

 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled.

It can be detrimental to Redis' performance, more info here: http://antirez.com/news/84

Should probably be a oneliner to add it to run.sh.