smilligan93 / max-crit-foundry-dnd5e Goto Github PK

Hi,

Let me begin that I'm very happy with this module as it is working now, however I have a request. One of my house rules for DnD5e is that the critical hit die is maximised as it is now thanks to your module for PC-only. However NPCs and creatures only get the normal critical hit rules (this is due to the fact that monsters have crazy damage die's sometimes and this would cause more player death than I would like). Your module seems to Max our critical hits for everyone.

Is it possible to add a toggle in the MaxCrit settings where you could enable MaxCrit PC-only?

Hello! This is neat :)

Is there a way to add brutal critical hits for a barbarian into this? It only ever does the first damage dice.

Thanks for making this, removes a lot of number entry in foundry!

Regards, Me.

First, thank you so much for making this! I was wondering if it would be possible for you to add an additional setting. I do my crit die a little differently than RAW and fully Max. I like to max the first die of the attack and then leave the extra crit die as normal. For example, if I crit with a greataxe, that's RAW 2d12 damage. Under this mod, it would be 24. However, what I'm looking for is 12 (maxed first die) + 1d12. If there are any other die (like from Divine Smite, or the half-orc feature) they are also rolled as normal. For spells, such as Guiding Bolt, it works the same. Instead of 8d6 maxed out, I would do 6 + 7d6. Does this make sense? Is this something that could possibly be added as a feature?

Bug: If you use 3d6dl (drop lowest) for a damage roll, it gives 18 as damage instead of 12 on a max-crit

dnd5e changed how damage rolls work in 5e:

https://gitlab.com/foundrynet/dnd5e/-/blob/release-088/module/dice.js

The manifest URLs both link to the same json file.
https://foundryvtt.com/packages/max-crit/

I've attached the screenshot. Module is enabled, Foundry 0.5.7 DND5e 0.9

When rolling a damage roll from an item, for example 3d6dl (drop lowest), it doesn't have the right outcome. For example, I get 3d6dl + mod + 18, but it should be 3d6dl + mod + 12. Any idea what is going wrong?

Also the rollDamage code has been changed in recent Foundry versions and is now different than the override used in Max-Crit module. I think this may cause issues at the moment, or in the future.

This module is preventing cantrip scaling in DnD5e 0.96

I use a house rule that you roll your normal damage dice, and add that to a maxed crit dice. Would be good to have that as an option in this script

Add the ability to "roll" the bonus dice from feats on crits, i.e. savage attacks, Brutal Critical

Will Max Crit be made compatible with Foundry 0.8?