smol-rs / easy-parallel Goto Github PK

Would it be possible/desirable for finish (and run) to behave like collect ?

By replacing this :

pub fn finish<F, R, I>(self, f: F) -> (I, R)
where
    F: FnOnce() -> R,
    T: Send + 'a,
    I: std::iter::FromIterator<T>
{
    /* ... */
    let results: I = receivers.into_iter()
        .map(|receiver| receiver.recv().unwrap())
        .collect();
    /* ... */
}

Maybe by adding a generic collect consuming method (like run), which would then be used internally by finish (without changing its signature) ?

The derived Default implementation, as documented here, places an unnecessary T: Default bound. This can be fixed by using a manual implementation instead (which could just call Parallel::new()).