socialmoney / corepro-sdk-java Goto Github PK

For the domain objects, Customer and ExternalAccount, the method getByTag throws an error.

The error is:

Caused by: java.util.IllegalFormatConversionException: d != java.lang.String
    at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
    at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
    at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
    at java.util.Formatter.format(Formatter.java:2520)
    at java.util.Formatter.format(Formatter.java:2455)
    at java.lang.String.format(String.java:2940)
    at io.corepro.sdk.ExternalAccount.getByTag(ExternalAccount.java:105)
    at io.corepro.sdk.ExternalAccount.getByTag(ExternalAccount.java:99)
    at com.bmo.benjamins.service.CoreProServiceWrapperImpl.verifySourceAccount(CoreProServiceWrapperImpl.java:107)
    at com.bmo.benjamins.service.CoreProFundService.verifySourceAccount(CoreProFundService.java:78)

I notice in the method signatures that the getByTag functions take an integer, customerId, in addition to a Tag.

https://github.com/socialmoney/corepro-sdk-java/blob/master/io.corepro/src/io/corepro/sdk/Customer.java#L130

My understanding is that the purpose of getByTag is that it should not require the Customer's ID. Also, the API documentation shows only tag as a required field.
https://docs.corepro.io/api/customer/getbytag

I've noticed this issue with Customer and ExternalAccount objects, but I haven't checked to see if there are other domain objects affected.

In our code, we need to verify an external account.

First, we are getting the ExternalAccount object with the customer ID and external account ID. This step is succeeding without any errors.

ExternalAccount account = ExternalAccount.get(
    request.getCustomerId(),
    request.getExternalAccountId(),
    connection,
    null
);

However, when we call account.verify(), this step is failing even though the account exists in core pro.

return account.verify(
    request.getAmountOne(),
    request.getAmountTwo(),
    connection,
    null
);

This is the exception that is being thrown:

CoreProApiException: Invalid ExternalAccountId '305014' See Errors property for full list of error details.

We have also tried using ExternalAccount.getByTag(), but always get the same results.

While I am not positive whether this is a problem with the SDK or the CorePro sandbox, I have had success testing this process against the CorePro sandbox API, but I haven't been able to replicate it using this SDK.