Comments (2)
tombaeyens
commented on May 21, 2024
Not sure if there is a simple fix for this. I'm think the parsing has to get a serious rework.
Atm, we delegate merge the parsing of the check line and then the parsing of the optional check details. When the check line is parsed, the antlr parser is straight connected to the error message logs.
I think we should decouple that. The Antlr parser logs are way worse than I expected. I think we should just do the whole antlr parsing as a single operation that fails or succeeds. And then just produce 1 error log saying that the check line is invalid without further detail.
Other thoughts on how we could fix this more simple?
from soda-core.
tombaeyens
commented on May 21, 2024
Merged into #1234
from soda-core.
Related Issues (20)
- invalid_count block other tests execution HOT 2
- OAuth connection for Trino/Starburst HOT 1
- Add prerequisite option to check configuration HOT 1
- SodaCore 3.0.48 is not compatible with Airflow 2.7 HOT 2
- Duplicate count throw TypeError if column not exist HOT 2
- Parser does not support otherwise legal table valued functions HOT 1
- [test] Testing the updated integration HOT 1
- Profiler frequent_values Error When There's only one unique value in column: Source - Trino HOT 2
- Error connection with SQL and param string Trusted_Connection=True HOT 4
- Schema checks not working for DuckDB connection HOT 4
- Antlr doesn't parse composite threshold in freshness check HOT 2
- duplicate_count semantics are unclear and surprising HOT 1
- Invalid section header for dremio data path HOT 3
- Regex pattern issue for (at least) SQL Server data source HOT 1
- "Between" threshold produces warning when using variables HOT 1
- Functions from PostGIS extensions can not be found HOT 1
- Slack soda-community access HOT 1
- Datahub intergration HOT 2
- Update Pydantic dependency HOT 1
- MySQL library installation Windows bluescreen HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from soda-core.