Setup doc: Eigen confusion about doc HOT 6 CLOSED

actually that does not seem to be the case anymore, not sure what happened - anyways from the documentation is not clear what needs to be done so that CMake can find it (or auto-fetch like it used to?)

from doc.

You noticed it correct @IngmarVoigt2
Eigen was first pulled directly when configuring SOFA and it was not appearing in the dependencies (and in the build documentation). This had two main drawbacks: first the dependency did not appear clearly as is, and second, some configuration were messing up when eigen was already installed on the system,

It has therefore been decided to homogenize the setup and make it as a clear dependency which has to be installed in the system, as it is now explained in the documentation. See PR #1281

What would you suggest for a change in the documentation ?

from doc.

I see, thanks for adding context @hugtalbot !

So this is in fact a very recent change, which is "only" on master and not part of the latest official release (v19.12.00 from Jan 20) but only forthcoming ones, right? Therefore https://github.com/sofa-framework/doc/blob/master/10_Getting_Started/20_Build/30_Windows.md is actually inconsistent, since it explicitly recommends getting v19.12

To solve I would suggest to explicitly point out that:

1. v19.12.00 still pulls eigen during Cmake cfg, prb in the "Dependencies" section (for reference purposes so that anyone still using old branches on purpose would not run into the same confusion)
2. the new releases (after v19.12.00) actually require to manually set the EIGEN3_ROOT cmake var (similarly like for Qt and Boost)

Would that make sense?

from doc.

p.s. I was actually able to fix the auto-pull in my clone: apparently my clone was messed up somehow, so I did a git reset --hard to fix (which might also be a good fit for the troubleshooting section of the same doc)

from doc.

Hi @IngmarVoigt2
Thanks for sharing the solution you have.

Regarding the documentation, next release 20.06 will integrate these changes. The documentation is a bit in advance (and misleading) but only for the next 1.5 month. Moreover, in the case 1. you describe (<=19.12) everything is automatic and transparent.

I just made a PR #35 for this, let me know if it would have helped.

From June, everything should now be stable in one or the other configuration.

from doc.

from doc.