Giter VIP home page Giter VIP logo

sofa-build's People

Contributors

glmapper avatar khotyn avatar leizhiyuan avatar qilongzhang avatar straybirdzls avatar ujjboy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sofa-build's Issues

Remove dependency management for netty-all

Spring 2.0 already manage netty version as below in spring-boot-dependencies:

 <netty.version>4.1.25.Final</netty.version>

<dependency>
    <groupId>io.netty</groupId>
    <artifactId>netty-bom</artifactId>
    <version>${netty.version}</version>
    <type>pom</type>
    <scope>import</scope>
</dependency>

In sofa-build , we manage netty-all

<netty-all.version>4.1.6.Final</netty-all.version>
<dependency>
    <groupId>io.netty</groupId>
    <artifactId>netty-all</artifactId>
    <version>${netty-all.version}</version>
</dependency>

this will cause some conflicts such as:

Caused by: java.lang.NoClassDefFoundError: Could not initialize class io.netty.channel.ChannelOutboundBuffer
	at io.netty.channel.AbstractChannel$AbstractUnsafe.<init>(AbstractChannel.java:421)
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.<init>(AbstractNioChannel.java:218)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.<init>(AbstractNioByteChannel.java:72)
	at io.netty.channel.socket.nio.NioSocketChannel$NioSocketChannelUnsafe.<init>(NioSocketChannel.java:457)
	at io.netty.channel.socket.nio.NioSocketChannel$NioSocketChannelUnsafe.<init>(NioSocketChannel.java:457)
	at io.netty.channel.socket.nio.NioSocketChannel.newUnsafe(NioSocketChannel.java:454)
	at io.netty.channel.socket.nio.NioSocketChannel.newUnsafe(NioSocketChannel.java:49)
	at io.netty.channel.AbstractChannel.<init>(AbstractChannel.java:80)
	at io.netty.channel.nio.AbstractNioChannel.<init>(AbstractNioChannel.java:84)
	at io.netty.channel.nio.AbstractNioByteChannel.<init>(AbstractNioByteChannel.java:54)

sofaboot-dependencies should only have lookout starters and lookout registry extensions

Current sofaboot-dependencies have a lot of lookout dependencies, such as lookout-common, lookout-api and etc.

When user want to change the lookout version, he can't just change the the lookout starter version but also have to add all the lookout dependencies.

Otherwise, will result in the following situation, for example:

Change the project's lookout version to a snapshot version:

<dependencies>
    <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-web</artifactId>
    </dependency>
    <dependency>
        <groupId>com.alipay.sofa.lookout</groupId>
        <artifactId>lookout-sofa-boot-starter</artifactId>
        <version>1.5.2-SNAPSHOT</version>
    </dependency>
    <dependency>
        <groupId>com.alipay.sofa.lookout</groupId>
        <artifactId>lookout-reg-prometheus</artifactId>
        <version>1.5.2-SNAPSHOT</version>
    </dependency>

    <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-test</artifactId>
        <scope>test</scope>
    </dependency>
</dependencies>

The dependencies of the project will be:

image

which could cause NoSuchMethodError or other problem.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.