soft-matter-theory-at-icmab-csic / chitin_builder Goto Github PK

Hi @jfaraudo, I've started my review and will file issues here. I'm working on the review now so I'm going to edit this comment as I go.

The following review checklist items require changes:

• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Requested Change: Please use the uppercase LICENSE for the license file's name
• Paper: The paper has far too much content at this point and should be shortened considerably. Please review https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain. I think you could reduce your Introduction and Statement of Need section into just a Statement of Need section into three paragraphs, mostly containing the text at the end of the existing section. Remove Methods, Program description, use and features, Examples, Compatibility and distribution.

Non-review-checklist items:

• Update Zenodo citation to match auto-generated citation
• Try to use the name "Chitin Builder" everywhere, updating any alternative usages
• Had an issue opening the documentation from the Chitin Builder GUI. Filed #4.

Hi,
In ForceField directory, the readme says "File with CHARMM36 carbohydrate force field parameters including chitin as BGNA residue." However, I cannot find the corresponding topology file with residue name BGNA.

While reviewing in #3, I noticed the "Documentation..." menu item under the Help menu in Chitin Builder opens my browser to https://bitbucket.org/icmab_soft_matter_theory/chitin_builder_gui/src/master/ which doesn't exist.