Release does not have JS files for bundling. Gulp fails about ngx-bootstrap-multiselect HOT 17 CLOSED

Created a pull request for the package owner to review. This should be resolved as soon as the pull request is merged and the npm package updated.

from ngx-bootstrap-multiselect.

@ortichon, sorry. Work got really busy and I haven't actually contributed any code to the project yet. I'll try to get it up and running this weekend, if nothing else gets in the way.

from ngx-bootstrap-multiselect.

@nicholasguyett I tried do npm install and I got the .js .js.map files. Can you check again?

from ngx-bootstrap-multiselect.

I've ran into the same issue. I'll try to the source control configured to generate the JS and D files sometime this week. I'll ping @softsimon to update the NPM package once I've done that.

from ngx-bootstrap-multiselect.

@nicholasguyett any update?

from ngx-bootstrap-multiselect.

@nicholasguyett hi! how do we use this? Im still seeing only the TS file in the repo.

from ngx-bootstrap-multiselect.

If you're pulling directly from the repository, you have to run tsc from the repository root. It will build the js files needed. The idea is the compiled JS will be pushed to NPM.

from ngx-bootstrap-multiselect.

ah got it, noticed this isnt updated on npm yet so got a bit confused. Thanks!

from ngx-bootstrap-multiselect.

from ngx-bootstrap-multiselect.

Just published a new version. Just comment if something is missing.

from ngx-bootstrap-multiselect.

@softsimon @nicholasguyett I just tried this, still getting only the ts file in node_modules for version 0.3.2 (latest). Needed to run the tsc command to get it working still

from ngx-bootstrap-multiselect.

@softsimon, sorry, I think I missed a part of my explanation. I avoided checking in the compiled js files into the project, for source control best practice reasons, but the fix for this was supposed to be having the npm package include the compiled JS files.

So, after tsc is run, the compiled js and map file would be uploaded to the npm package. I've never added an NPM package before, so I thought it was possible to include compiled files in the package that aren't in the repository.

from ngx-bootstrap-multiselect.

@softsimon , @nicholasguyett when you planed update npm with builded js file?

from ngx-bootstrap-multiselect.

I don't know when NPM will be updated, but I think I did find out why the compiled JS was not included in the project.

According to the documentation on npm publish, npm automatically ignores fies in the gitignore file. If one also adds a .npmignore that does not also exclude the file, npm will include it in the package.

@softsimon, can you pull the latest and publish a new npm package with the compiled JS? If you run tsc before publishing I believe it should include the compiled JS in the package, which should resolve this task.

from ngx-bootstrap-multiselect.

@nicholasguyett I'll try! I was unsure what the correct way was to handle this situation.

from ngx-bootstrap-multiselect.

Did you run tsc before publishing? The js files are still missing, but I'm not sure if its because I messed up the configuration or the js files were not generated.

from ngx-bootstrap-multiselect.

Sorry, I accidentally looked at the release files on github rather than the npm package. You are correct.

from ngx-bootstrap-multiselect.