solidusio / solidus_gateway Goto Github PK

View Code? Open in Web Editor NEW

45.0 45.0 62.0 366 KB

A collection of payment methods for Solidus

Home Page: https://solidus.io

License: BSD 3-Clause "New" or "Revised" License

Ruby 92.91% HTML 7.09%

payment solidus

solidus_gateway's People

Contributors

Stargazers

Watchers

solidus_gateway's Issues

Error due to spree/api/payments/source_views

Steps to reproduce
Iam getting error in orders that not load shipment and line items, I realized debugging that gets error because doesn't exist _stripe.json.jbuilder in spree/api/payments/source_views

This file 'sources_views' has been created 1 month ago in solidus master.

System configuration
Solidus master last version, solidus_stripe

undefined method 'track_data' for #<Spree::CreditCard:0x007fdbe249a2f8>

I'm getting the following error using AuthorizeNet as provider in the gateway payment methods:

I tried defining track_data and returing false to see if magically works on Spree::CreditCard but then I ran into another issue

undefined method 'valid_card_verification_value?'

No translation option for stripe errors

I am trying to translate stripe errors but I have to override the stripe code in order to achive it, beacuse insert the code below in the payment view doesn´t work.

Are there any option to do it in a right way?
var errorMessages = {
incorrect_number: "Número de tarjeta incorrecto",
invalid_number: "EL número de tarjeta no es un número de tarjeta válido",
invalid_expiry_month: "El mes de caducidad de la tarjeta no es válido",
invalid_expiry_year: "El año de caducidad de la tarjeta no es válido",
invalid_cvc: "El código de seguridad de la tarjeta no es válido",
expired_card: "La tarjeta ha caducado",
incorrect_cvc: "Código de seguridad de la tarjeta incorrecto",
incorrect_zip: "Falló la validación del código postal de la tarjeta",
card_declined: "La tarjeta fué rechazada",
missing: "El cliente al que se está cobrando no tiene tarjeta",
processing_error: "Ocurrió un error procesando la tarjeta",
rate_limit: "Ocurrió un error debido a consultar la API demasiado rápido. Por favor, avísanos si recibes este error continuamente"
}

if(response.error){
    $('#stripeError').html(errorMessages[response.error.code]);
    $('#stripeError').show();
} else {
    Spree.stripePaymentMethod.find('#card_number, #card_expiry, #card_code').prop("disabled" , true);
    Spree.stripePaymentMethod.find(".ccType").prop("disabled", false);
    Spree.stripePaymentMethod.find(".ccType").val(mapCC(response.card.type))
    token = response['id'];
    // insert the token into the form so it gets submitted to the server
    Spree.stripePaymentMethod.append("<input type='hidden' class='stripeToken' name='subscription[card_token]' value='" + token + "'/>");
    Spree.stripePaymentMethod.parents("form").get(0).submit();
}

}

Missing existing_payment views

The Solidus commit https://github.com/solidusio/solidus/pull/1707/files added a partials folder called existing_payment, but there are no such views in the master branch of solidus_gateway.

This means that users using Stripe and Quick Checkout will cause 500 errors when they try to check out.

This is a show-stopping issue, as it literally breaks checkout in some Stores.

What we need: views in the spree/checkout/existing_payment/ path for Stripe and Quick Checkout. I’m not sure what these views are supposed to look like exactly, so I’m not sure what the PR would be here. But this is an urgent issue for anyone using Solidus 2.2 and Stripe or Quick Checkout in production.

stripe gateway error

Hi, installed solidus_gateway gem version 1.1.1, got this error message when submitting a payment request to stripe

Amount must be at least 50 JPY

I've confirmed that the total amount of order is 2000 JPY, could you help to check?

checkout/existing_payment/_stripe partial not found

This commit, merged into master, seems to add checkout/existing_payment/_stripe:

5a4fed1

But that commit isn't in v1.2.0, and as a result I don't have a checkout/existing_payment/_stripe partial, which this code tries to load:

<%=
  render(
    partial: "spree/checkout/existing_payment/#{wallet_payment_source.payment_source.payment_method.partial_name}", locals: {wallet_payment_source: wallet_payment_source, default: wallet_payment_source == @default_wallet_payment_source}
    )
%>

Checkout hangs on incorrect Braintree configuration

I ran into an issue today where the checkout in the dummy app would hang indefinitely if the Braintree gateway was misconfigured. Ideally the app should throw an error in this situation.

Steps to reproduce

Set up a sandbox account on Braintree
Generate and run the dummy application for testing
Log in to the admin and create a new payment method using the Braintree gateway
Edit the payment method and enter Braintree credentials for your sandbox account
Set the environment to development (this is the issue)
Checkout as a normal user using the Braintree payment method
After selecting Save and Continue on the payment step, the application should hang

If the environment is set to sandbox for the Braintree payment method, the order is processed successfully.

Authorize Net - Not Processing Payments

Payments get processed for other gateways like Stripe, but failed for Authorize Net.

Gateway Error
--- !ruby/object:ActiveMerchant::Billing::Response
params:
action: :authorize
response_code:
response_reason_code: '3'
response_reason_text: The 'AnetApi/xml/v1/schema/AnetApiSchema.xsd:cardNumber' element
is invalid - The value XX is invalid according to its datatype 'String' - The
actual length is less than the MinLength value
avs_result_code:
transaction_id:
card_code:
authorization_code:
cardholder_authentication_code:
account_number:
test_request:
message: The 'AnetApi/xml/v1/schema/AnetApiSchema.xsd:cardNumber' element is invalid

The value XX is invalid according to its datatype 'String' - The actual length
is less than the MinLength value
success: false
test: true
authorization: "##authorize"
fraud_review: false
error_code:
emv_authorization:
avs_result:
code:
message:
street_match:
postal_match:
cvv_result:
code:
message:

Ironically, for order.state 'confirm', payments do get through for Authorize Net, but failed for order.state 'complete'.

Did anyone experience this behavior?

BeansteamGateway loading

/app/models/spree/gateway/beanstream.rb:77:in `<class:Beanstream>': uninitialized constant ActiveMerchant::Billing::BeanstreamGateway (NameError)

dependency added two times

Since last commit ffaker was added in Gemfile and in gemspec. And I think is enough to be in one place.

I prefer to add in Gemfile since this is just necessary to avoid an error when run tests and isn't used for the gem itself.

What do you think? @tvdeyen @swcraig

Stripe not working through solidus_gateway.

when i am trying to use stripe through solidus_gateway i am getting a token issue because i am getting gateway_payment_profile_id as string instead of an object.

Deprecation warning from stripe

/home/jhawthorn/.gem/ruby/2.3.1/gems/activemerchant-1.60.0/lib/active_merchant/billing/gateways/stripe.rb:293:in `create_post_for_auth_or_purchase': Passing the customer in the options is deprecated. Just use the response.authorization instead.

tests do not run correctly on solidus_gateway master -- Factory already registered: skrill_quick_checkout

jason@Jasons-MB-Air-2:solidus_gateway (master)$ be rspec spec/*
Coverage report generated for RSpec to /Users/jason/Projects/Mack-Weldon/solidus_gateway/coverage. 332 / 828 LOC (40.1%) covered.
/Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/decorator.rb:10:in `method_missing': Factory already registered: skrill_quick_checkout (FactoryGirl::DuplicateDefinitionError)
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/decorator/disallows_duplicates_registry.rb:6:in `register'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:70:in `block in register_factory'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:69:in `each'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl.rb:69:in `register_factory'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:20:in `factory'
    from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/factories/skrill_factory.rb:2:in `block in <top (required)>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:49:in `instance_eval'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:49:in `run'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/syntax/default.rb:7:in `define'
    from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/factories/skrill_factory.rb:1:in `<top (required)>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `block in load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:240:in `load_dependency'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:20:in `block (2 levels) in find_definitions'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:19:in `each'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:19:in `block in find_definitions'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:15:in `each'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/factory_girl-4.5.0/lib/factory_girl/find_definitions.rb:15:in `find_definitions'
    from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/spec_helper.rb:49:in `block in <top (required)>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core.rb:97:in `configure'
    from /Users/jason/Projects/Mack-Weldon/solidus_gateway/spec/spec_helper.rb:22:in `<top (required)>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `block in load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:240:in `load_dependency'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/activesupport-4.2.5/lib/active_support/dependencies.rb:268:in `load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1361:in `block in load_spec_files'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `each'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/configuration.rb:1359:in `load_spec_files'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:102:in `setup'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:88:in `run'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:73:in `run'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/lib/rspec/core/runner.rb:41:in `invoke'
    from /Users/jason/.rvm/gems/ruby-2.1.5/gems/rspec-core-3.4.1/exe/rspec:4:in `<top (required)>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/bin/rspec:23:in `load'
    from /Users/jason/.rvm/gems/ruby-2.1.5/bin/rspec:23:in `<main>'
    from /Users/jason/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
    from /Users/jason/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'

Incomplete list of gateways in admin

Hi,
I've noticed that the list in the admin doesn't show all the gateways available in ActiveMerchant. For example: PayuLatam appears as available in ActiveMerchant but not in Solidus Gateway. Is there a way to add it?
https://github.com/activemerchant/active_merchant/blob/master/lib/active_merchant/billing/gateways/payu_latam.rb

Thanks!

SpreeGateway adds UsaEpay twice

Just looking at the code to see what's supported and noticed UsaEpay is in there twice...

If a address step exists in checkout for shipping address and not billing payment crashes

undefined method `full_name' for nil:NilClass

_stripe.html.erb line 71

Can't use stripe as payment method

I've added gateway, ran migrations, set it up from admin panel, added stripe keys.
When I try to pay for a product I get

Missing partial spree/checkout/payment/_stripe with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :coffee, :slim, :rabl], :versions=>[:v10, :v9, :v8, :v7, :v6, :v5, :v4, :v3, :v2, :v1]}. Searched in:
  * "/Users/andrei/dev/ezworks/danieldiamondsny/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_auth_devise-1.4.0/lib/views/backend"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_auth_devise-1.4.0/lib/views/frontend"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/devise-3.5.10/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_frontend-1.2.2/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_backend-1.2.2/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_api-1.2.2/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/solidus_core-1.2.2/app/views"
  * "/Users/andrei/.rvm/gems/ruby-2.3.0/gems/kaminari-0.17.0/app/views"

Gems

    solidus (1.2.2)
      solidus_api (= 1.2.2)
      solidus_backend (= 1.2.2)
      solidus_core (= 1.2.2)
      solidus_frontend (= 1.2.2)
      solidus_sample (= 1.2.2)
    solidus_api (1.2.2)
      rabl (>= 0.9.4.pre1, < 0.12.0)
      solidus_core (= 1.2.2)
      versioncake (~> 2.3.1)
    solidus_auth_devise (1.4.0)
      deface (~> 1.0.0)
      devise (~> 3.5.1)
      devise-encryptable (= 0.1.2)
      json
      multi_json
      solidus_core (>= 1.0.6, < 2)
    solidus_backend (1.2.2)

...

    solidus_frontend (1.2.2)
      canonical-rails (~> 0.0.4)
      jquery-rails
      solidus_api (= 1.2.2)
      solidus_core (= 1.2.2)
    solidus_gateway (1.0.1)
      solidus_core (~> 1.1)
    solidus_sample (1.2.2)
      solidus_core (= 1.2.2)

I see that template exists at https://github.com/solidusio/solidus_gateway/blob/master/lib/views/frontend/spree/checkout/payment/_stripe.html.erb, but my app doesn't look for it there. what are the reasons? how would I fix it?

Paya via Solidus?

What's the preferred method of handling Paya (previously known as Sage Payment Solutions) in Solidus?

Amazon payments

is there any guide to enable/use amazon payment? already try to use solidus_amazon_payments but not sure if is that required for solidus_gateway, since the amazon option is not displayed on the checkout.

solidusio / solidus_gateway Goto Github PK

solidus_gateway's People

Contributors

Stargazers

Watchers

Forkers

solidus_gateway's Issues

Recommend Projects

Recommend Topics

Recommend Org