Giter VIP home page Giter VIP logo

grunt-zip-to-crx's People

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

grunt-zip-to-crx's Issues

Async done missplaced

Hey guys,
I found that you async callback function is not well implemented inside your code, thus,e.g., if after you code invoke i`d like to clean the zip file it will stack execution and will not clean the zip file. The problem is in this function:

  var options, filesList, allInputFilesTripples, CrxCreatorConstructor, crxCreator, done;
**done = this.async();** 
......
  /*was changed by Alex*/
error = zipsToCrx.thickThing(options, allSrcZips, crxDestination, originalSrcZip, filesTripple.orig.dest,**done**  /*function(){}*/, function(error) {
    grunt.log.warn(error);
  });
});

I just provide the async done function instead of your empty anonymous function to thickThing(),

For you review.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.