soniyaprasad77 / portfolio Goto Github PK
View Code? Open in Web Editor NEWHTML, CSS and JavaScript ↹ ReactJs and TailwindCSS
HTML, CSS and JavaScript ↹ ReactJs and TailwindCSS
I recently came across your repository and noticed a few areas that could be improved for better code management and readability:
Folder Structure: The repository currently lacks a clear folder structure. Having a well-defined folder structure makes it easier for contributors to locate files and understand the flow of the code.
.gitignore File: There is no .gitignore
file in the repository. This file is important to avoid committing unnecessary files to the repo (like .log, .cache .DS_STORE, etc.).
File Names: Some of the file names are not clear (e.g., 'istockphoto-903044512-170667a.jpg', '7ca7cd84-b514-4d79-862a-3b7f508e31eb.png' etc). It would be helpful if the files were named in a more descriptive way, following a consistent naming convention.
Link Paths: The repository currently uses absolute paths for links. This could lead to broken links if the URL of your profile changes or if the project is moved to another repository under a different name. It's recommended to use relative paths instead.
index.html
:
I suggest the following solutions to above mentioned issues:
Static Files:
I noticed that static files such as .js
,.css
and favicon icons are currently in the root directory. It would be more efficient to store these in a static/
directory. Inside the static/
directory, you could create sub-directories for each type of file (e.g., a js/
folder for JavaScript files and a css/
folder for CSS files). Given that your portfolio doesn't have multiple JavaScript or CSS files, it's fine to create only one folder and store these files into static
folder.
Media Files:
Similarly, media files like images and PDFs could be moved into a media/
directory. Inside the media/
directory, you can create sub-folders for different types of media (e.g., an images/
or img/
folder for images and a doc/
folder for PDFs).
.gitignore File:
Visit gitignore.io and enter the types of files you want to ignore (e.g., Windows, macOS, Linux, VisualStudioCode). This site generates a .gitignore
file that helps GitHub ignore certain hidden files that are not necessary to track, such as the .DS_STORE
file often generated on macOS. Adding this .gitignore file to your repository will prevent these types of files from being tracked by Git.
In my recommendation, I've covered most of the IDEs used for web development. You can copy-paste from this link
.gitignore
file in the root folder of your project..gitignore
file.git add .gitignore
git commit -m "Added .gitignore file"
git push
Link Paths:
Review the code and convert all absolute paths to relative paths. For example, if there's a link to an image like https://raw.githubusercontent.com/soniyaprasad77/soniyaprasad77.github.io/main/logo.png
, it should be changed to ./static/logo/logo.svg
(assuming the HTML file is in the root directory and you've static/logo
folder where logo is stored).
This approach ensures that the links will continue to work correctly, even if the profile link updates or the project is moved to another repository under a different name.
Given the number of improvements suggested, this issue could be considered a "mega issue". To make it more manageable, I recommend breaking it down into smaller sub-issues, each targeting a specific improvement. (for better understanding, refer Github Doc on task list)
Here's a possible breakdown:
Each sub-issue can be tracked with a task list in this mega issue. As each sub-issue is resolved, its corresponding task can be checked off. This approach will make it easier to track progress and keep the project organised.
I hope these suggestions are helpful!
Happy coding
💯
A Slide Entry Animation for different sections.
I feel the fonts of the application can be improved.
Some of the file names are not clear (e.g., istockphoto-903044512-170667a.jpg
, 7ca7cd84-b514-4d79-862a-3b7f508e31eb.png
etc). It would be helpful if the files were named in a more descriptive way, following a consistent naming convention.
Rename the file names to be descriptive and short such as if it logo png file then for example keep the name logo.png
. Similarly, if it profile photo or PDF file then give good descriptive name like profile-xs-screen.png
for smaller screen or resume.pdf respectively.
Is your feature request related to a problem? Please describe.
The current about page lacks visual appeal and animations.
Describe the solution you'd like
I'd like to enhance the visual appeal of the webpage by adding animations to existing images. Additionally, I want to incorporate a new shape element to improve the overall aesthetics of the page.
Describe alternatives you've considered
An alternative solution could be to revamp the entire webpage layout or to use a different set of images. However, I believe that adding animations and a new shape is a more cost-effective and visually pleasing solution.
Additional context
I have already made the necessary code changes for the animated images with an added shape. The animations and styling are expected to provide a better user experience and enhance the overall aesthetics of the webpage.
Please review and consider these changes for approval and integration into the project.
I have reviewed your portfolio. Though I found some issues which I can fix.
Issues : contents not managed on certain device, also your navbar is bulky for mobile devices.
Please assign this issue to me and tag it with hacktoberfest !!
Looking forward to contribute in your project
view code and view projects are clickable events, i think they should be buttons
please assign me this issue @soniyaprasad77
Is your feature request related to a problem? Please describe.
The profile image in the about section is not properly aligned , therefore, it looks unsymmetrical.
Describe the solution you'd like
An addition of CSS property in the respective class must be made to make the image aligned.
Describe alternatives you've considered
No alternatives
Additional context
Hey there, @soniyaprasad77!
I'd like to make a certain changes to 'About Me' section:-
Attached screenshots describe the changes:
Kindly assign me the issue under appropriate tags
Thank You!
I hope you're well. I'd like to request permission to work on a sticky navbar feature for our repository. This enhancement will keep the navbar at the top of the screen as users scroll, improving user experience and navigation.
Here's what you can expect from this implementation:
User Experience: Enhanced navigation and improved user engagement.
Compatibility: Extensive testing to ensure cross-browser and responsive compatibility.
Accessibility: Adherence to accessibility standards for a wider user base.
Performance: Careful optimization to prevent performance issues.
I'm ready to create a dedicated branch, develop the feature, and submit pull requests for review. Your guidance and any specific requirements you have are highly valued.
Looking forward to your response.
The website needed some improvements to make it look refreshed and updated!
Describe the solution you'd like
The logo of Twitter should be updated, the about text should be justified, and since there is nothing related to more sections, something like a blog section can be added!
Describe alternatives you've considered
Since the website is already well formatted with a nice theme of black and pink just improving the styling of some items can make it super fantastic!
The current Navbar doesn't fit well with the color code of the portfolio site and also looks outdated. The background color is too dark and the text is hard to read. The links are not aligned properly and the hover effect is not smooth.
The laptop background image on the homepage is noticeably low quality.
Is this image your or where did you get this from? Do you have any preference for the new image if you want me to find free photo version to replace?
You could assign me under Hacktoberfest 2023 once we figure out the answer above. I have photoshop skills to use as well to edit for the same issue for mobile version.
Thanks!
I would like to contribute fixes for:
As a frontend developer, I can provide CSS/SCSS changes to implement these typography and whitespace improvements. This would make the site easier to parse and improve retention.
Kindly tag this issue under hacktoberfest/hacktoberfest-accepted and assign it to me so I can make a pull request with my changes. @soniyaprasad77, Let me know if you have any other ideas for enhancing the site UX!
Add review section for your projects so that visitors can know the point of view of others and have a better experience about your projects.
Please assign this issue to me.
Thanks!
The current Readme file for the project provides an overview of the project, but there is room for improvement in terms of clarity, organization, and overall user-friendliness. This issue aims to enhance the Readme file to make it more informative and accessible to both new and experienced users and contributors.
Can you assign this to me?
There is no .gitignore
file in the repository. This file is important to avoid committing unnecessary files to the repo (like .log, .cache .DS_STORE, etc.).
Visit gitignore.io and enter the types of files you want to ignore (e.g., Windows, macOS, Linux, VisualStudioCode). This site generates a .gitignore
file that helps GitHub ignore certain hidden files that are not necessary to track, such as the .DS_STORE
file often generated on macOS. Adding this .gitignore file to your repository will prevent these types of files from being tracked by Git.
In my recommendation, I've covered most of the IDEs used for web development. You can copy-paste from this link
.gitignore
file in the root folder of your project..gitignore
file. git add .gitignore
git commit -m "Added .gitignore file"
git push
The repository currently uses absolute paths for links. This could lead to broken links if the URL of your profile changes or if the project is moved to another repository under a different name. It's recommended to use relative paths instead.
index.html
:
Review the code and convert all absolute paths to relative paths. For example, if there's a link to an image like https://raw.githubusercontent.com/soniyaprasad77/soniyaprasad77.github.io/main/logo.png
, it should be changed to ./static/logo/logo.svg
(assuming the HTML file is in the root directory and you've static/logo
folder where logo is stored).
This approach ensures that the links will continue to work correctly, even if the profile link updates or the project is moved to another repository under a different name.
I think that in navigation bar there is a option more that of no use because it do same thing as contact do so we have to remove that.
The repository currently lacks a clear folder structure. Having a well-defined folder structure makes it easier for contributors to locate files and understand the flow of the code.
Static Files:
I noticed that static files such as .js
,.css
and favicon icons are currently in the root directory. It would be more efficient to store these in a static/
directory. Inside the static/
directory, you could create sub-directories for each type of file (e.g., a js/
folder for JavaScript files and a css/
folder for CSS files). Given that your portfolio doesn't have multiple JavaScript or CSS files, it's fine to create only one folder and store these files into static
folder.
Media Files:
Similarly, media files like images and PDFs could be moved into a media/
directory. Inside the media/
directory, you can create sub-folders for different types of media (e.g., an images/
or img/
folder for images and a doc/
folder for PDFs).
Additional context
Add any other context or screenshots about the feature request here.
Hi 👋🏼 ,
To help new contributors to contribute to your project, you might:
I'll be glad to do this for you as an Hacktoberfest contribution 😉
The Website is marvelous. The Thing which I would like to add is a "back-to-top" button which I general see in many of the websites.
This is the general UI update which I would like to add.
If its okay for you may I get assigned for it and start working on it??
Describe the bug
Scroll up button is visible even at the topmost position of page
Expected behavior
Scroll up button shouldn't visible at topmost position of page.
Additional context
I will fix this and also add relevant css styling for fading of it when reaches at top position.
@soniyaprasad77 please assign it to me sooner as deadline is near and I want to work upon it sooner
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.