sonph / gdaxcli Goto Github PK

• more unittests
• functional tests against the sandbox
• add continuous integration

The library has pretty poor exception handling, so we'll need to check the json output before processing it.

Since the api keys are sent with the requests, we are still able to send public requests such as get products or ticker without valid API keys.

Responses however need to be checked. #17.

Testing against the sandbox requires an API key so they have to be run locally. Maybe we should look into git hooks?

Maybe we can separate into panes, one with the repl and one with the live data?

This also means we'll need to rename the columns to something consistent, such as the keys in the repsonse json.

For example orders --columns=side,size,price

moar colors 🌈

tabulate looks like a good library.

Can configure travis-ci to test with most versions of python.

To print out values. This will help debugging issues. Make sure we don't log SENSITIVE information though.

So we can do

pip install gdaxcli
alias gdaxcli='python -m gdaxcli'

• mention the sandbox for testing
• create gif/asciinema demo
• explain what each field is

Hi @sonph, I'm not sure if I'm installing the app correctly. This is what I'm doing.

$ python2 -m virtualenv env
$ . env/bin/activate
(env) $ python -V
Python 2.7.13
(env) $ pip -V
pip 9.0.1 ...
(env) $ pip install gdaxcli
(env) $ python -m gdaxcli
.../env/bin/python: No module named gdaxcli

Any idea on how to resolve this?

• rename commands so it's easier to memorize
• maybe add autocomplete in REPL mode
• allow user to add aliases
• user friendly error messages

In config.py, for example:

FIAT_CURRENCIES = [
  'USD',
  # 'GBP',
  # 'EUR',
]

• add file config.sandbox.py
• add the --sandbox argument

I discovered that when order size exceeds the funds on the account order is executed with max size possible. Looks like the is i GDAX API engine.
I added some code to fix this.

gdax order market buy btc-usd 5.5
Not enough funds: 60690.85 USD required, 93.5376156937
available

order market sell ltc-btc 6.8
Not enough funds: 6.8 LTC required, 3.12091758 available

Fixed code is located at https://github.com/yg10/gdaxcli

• print out order details and ask for confirmation just before sending it off
• confirmation can be bypassed with -y or --yes

• order id should be shown when listing orders
• cancel with short order id (just short enough to uniquely identify an order)
• add confirmation
• cancel all