Comments (4)
If you call cb.Execute
in parallel, you can call too many beforeRequest
before afterRequest
.
from gobreaker.
If you call
cb.Execute
in parallel, you can call too manybeforeRequest
beforeafterRequest
.
AFAIK beforeRequest
will not executed in parallel since it has mutex
. I try to get ErrTooManyRequests
just last night, but couldn't get it.
from gobreaker.
Hi @tegaralaga
You can reproduce the ErrToManyRequests
by this test case.
func TestTooManyRequests(t *testing.T) {
customCB.setState(StateHalfOpen, time.Now())
// 3 consecutive successes
succeedLater(customCB, time.Duration(1000)*time.Millisecond)
succeedLater(customCB, time.Duration(1000)*time.Millisecond)
succeedLater(customCB, time.Duration(1000)*time.Millisecond)
time.Sleep(time.Duration(100) * time.Millisecond)
assert.Equal(t, Counts{3, 0, 0, 0, 0}, customCB.counts)
assert.Equal(t, succeed(customCB), ErrTooManyRequests)
}
from gobreaker.
I'm using the "two steps" circuit breaker and is very easy to get the ErrTooManyRequests
.
The problem is that after this error the state half open never change!
The state machine stuck by the condition mentioned in this issue:
if state == StateHalfOpen && cb.counts.Requests >= cb.maxRequests
Maybe this is a issue when use the "two steps" feature, but probably a public function to force a state or reset the counters would be helpful to handle this behavior.
from gobreaker.
Related Issues (20)
- start a new release? HOT 1
- println -> printf HOT 1
- [question/proposal] Monitoring
- breaker for host+service HOT 6
- Why don't use a rolling window to maintain the counts? HOT 4
- Where's the option for fallback function? HOT 5
- Create a new release for module support HOT 2
- Does this really require go 1.12? HOT 4
- race conditions HOT 1
- May I request a new release with tag HOT 2
- It will cause a deadlock when call breaker.Counts() method in the OnStateChange() method HOT 3
- breaker per url HOT 1
- example: HTTP circuit breaker doesn't consider HTTP status codes which are more indicative of retryable errors HOT 1
- Reproducing "too many requests"
- Circuitbreaker not performing MaxRequests operations in Half-open state HOT 3
- is circuit breaker threadsafe? HOT 1
- [question/proposal] Monitoring HOT 1
- Will using aync/atomic for incrementing and loading/storing the counts improve performance?
- Exported type for errors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gobreaker.