Comments (3)
hankji
commented on August 24, 2024
Same problem.
because all request must be success then state will be open in the interval duration.
look like it's a bug
Does anyone still maintain this repository?
from gobreaker.
DaChartreux
commented on August 24, 2024
According to "Release It! Design and Deploy Production-ready Software" book by Michael T. Nygard,
We make a single call in half open mode, if that fails, circuit breaker opens, else it closes.
For me, this was new coming from resilience4j
from gobreaker.
plabondutta
commented on August 24, 2024
@DaChartreux
But then again, if that is so, the MaxRequests settings shouldn't be present at all. This just doesn't make any sense.
from gobreaker.
Related Issues (20)
- start a new release? HOT 1
- println -> printf HOT 1
- [question/proposal] Monitoring
- breaker for host+service HOT 6
- Why don't use a rolling window to maintain the counts? HOT 4
- Where's the option for fallback function? HOT 5
- Create a new release for module support HOT 2
- Does this really require go 1.12? HOT 4
- race conditions HOT 1
- Confusion about ErrTooManyRequests error HOT 4
- May I request a new release with tag HOT 2
- It will cause a deadlock when call breaker.Counts() method in the OnStateChange() method HOT 3
- breaker per url HOT 1
- example: HTTP circuit breaker doesn't consider HTTP status codes which are more indicative of retryable errors HOT 1
- Reproducing "too many requests"
- is circuit breaker threadsafe? HOT 1
- [question/proposal] Monitoring HOT 1
- Will using aync/atomic for incrementing and loading/storing the counts improve performance?
- Exported type for errors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gobreaker.