Giter VIP home page Giter VIP logo

erik-test-visibility's Introduction

Code review exercise - Candidate instructions

This exercise is designed to give you an opportunity to demonstrate your frontend knowledge.

Scenario ๐ŸŒ„

One of your teammates was tasked with adding a 'Manage users page'. This will be part of a larger application and should load a list of users, display their data, and support removing said users from the list. They were provided with the following requirements:

  • Display the role and name for each user in a list.
  • Display a 'Delete' button next to each user, to remove them from the list.
  • Log to analytics whenever someone visits this page.

The developer has made these changes and wants help reviewing them!

Your task ๐Ÿ“

Under the Pull requests tab in this repo, you should find one open pull request (PR):

Screenshot showing GitHub 'Pull requests' tab

(If you're reading this on the repository home page, you can go directly to the PR.)

Your task is to review the proposed changes in the PR, look for any potential issues, and leave comments describing each one. When you are finished, you should submit the review. When submitting, you can also leave general feedback with any additional comments or thoughts you might have!

You have 1 hour for this submission

In summary:

  1. Find issues in the application and leave a review comment for each one. Write these comments as you would in a regular PR review. If you're unsure if something is an issue or not, you should still write a comment.
  2. Submit the review, including an overall comment/summary.

Important points

  • You should only review code in the provided pull request. Any other code is irrelevant for this task.
  • You should not worry about running the application, or attempting to review the design of the page. This exercise is focused entirely on reviewing the code.
  • When submitting, you do NOT need to explicitly "Approve" or "Request changes". This field will be ignored when we review your submission.

erik-test-visibility's People

Contributors

eseliger avatar

Watchers

Stephen Gutekanst avatar  avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.