spamexperts / directadmin-addon Goto Github PK
View Code? Open in Web Editor NEWSpamExperts plugin for the DirectAdmin control panel
License: GNU General Public License v2.0
SpamExperts plugin for the DirectAdmin control panel
License: GNU General Public License v2.0
It looks like the recent changes still haven't been made available on your download page. Is there any particular reason for that? It currently means we have to make a release ourselves and I prefer not to.
Latest versions.
Example:
Domain_create_post.sh is triggered but cannot succesfully run.
We need to add a 'hack' to make this work.
This only works when we add this into the file.
php -d disable_functions="" after the echo
Script does not run. Not enough permission to do so because of disabled function.
It does not seem to care what functions i enable or disable on the server for hosted PHP versions.
(There is also no information given what it needs and what server PHP version is used).
Plugin should work without this.
We run more plugins and never seen this before. There simply should be enough permissions present to make this work.
I don't know how others do this or are able to run this without this hack. It has been like this for us since i can remember. I created ticket multiple times for this but no real solution was given. Hoping with some plugin changes this would not be needed anymore since it's just unsafe.
Our directadmin addon currently requires plain text passwords in the configuration file. We should add support for login keys for more secure access control.
4.0.1508925016
We are testing on our server new Directadmin skin - evolution, that is in beta now, but will be released very soon. This is new default directadmin skin.
And there is some problem with your plugin in new skin.
When we try use check status link at any users
https://mail1.tuthost.com:2222/CMD_PLUGINS/spamexperts
we got error in console:
VM767:1 Uncaught SyntaxError: Unexpected token < in JSON at position 0
at JSON.parse ()
at Function.parseJSON (spamexperts?iframe=yes:5)
at parseAjaxResponse (spamexperts?iframe=yes:13)
at Object.success (spamexperts?iframe=yes:178)
at c (spamexperts?iframe=yes:5)
at Object.fireWith [as resolveWith] (spamexperts?iframe=yes:5)
at k (spamexperts?iframe=yes:7)
at XMLHttpRequest.r (spamexperts?iframe=yes:7)
And check button does not work. Maybe you could check your plugin work with new directadmin skin?
PHP Warning: Missing argument 2 for DirectAdmin_API::getDomainsMxRecords(),
called in /usr/local/directadmin/plugins/spamexperts/lib/SpamExperts_API.php on line 177
and defined in /usr/local/directadmin/plugins/spamexperts/lib/DirectAdmin_API.php on line 50
This was introduced in b76bf7b by myself. I'll submit a merge request hopefully later today.
Controlpanel DirectAdmin (Custombuild) 1.53.4
PHP version 7.2.9
Addon version 4.0.1508925016
There are errors when deleting or creating a domainname. DNS records are not changed due to this error.
This is on a freshly installed Centos 7 server with Directadmin Custombuild.
I did not have these issues with older servers. These older servers all use PHP-FPM 5.6 as main PHP version insead of 7.2.
Installing older addon versions onto this new server gives the same errors.
I installed a 2nd Centos server with Directadmin and got the same results. Exactly the same errors.
Errors on domain creation:
PHP Notice:
Undefined variable: output in /usr/local/directadmin/plugins/spamexperts/lib/Configuration.php on line 55
PHP Notice:
Undefined variable: return in /usr/local/directadmin/plugins/spamexperts/lib/Configuration.php on line 55
PHP Warning:
exec() has been disabled for security reasons in /usr/local/directadmin/plugins/spamexperts/lib/Configuration.php on line 55
PHP Notice:
Undefined variable: output in /usr/local/directadmin/plugins/spamexperts/lib/Configuration.php on line 57
PHP Warning:
implode(): Invalid arguments passed in /usr/local/directadmin/plugins/spamexperts/lib/Configuration.php on line 57
I enabled debug.
Only a prospamfilter_admin.log was created. Containing nothing generated when deleting or creating a domain name.
It did contain rules generated when protection is enabled for domain as Directadmin admin.
prospamfilter_admin.log below:
2018-09-26 23:08:23
Request login.antispamcloud.com/api/domain/exists/domain/xxxxx.com/format/json
HTTP 200
{"messages":{"error":["The domain 'xxxxx.com' does not belong to the admin '[email protected]'."]},"result":null}
2018-09-26 23:08:28
Request login.antispamcloud.com/api/domain/add/domain/xxxxx.com/destinations/["mail.xxxxx.com","relay.xxxxx.nl"]/format/json/
HTTP 200
{"messages":{"success":["'Email archiving' has been disabled for the domain 'xxxxx.com'","Email notifications for the domain 'xxxxx.com' changed to be sent from '[email protected]'","Domain timezone updated successfully","Administrator's contact email for the domain 'xxxxx.com' is changed to ''","Domain 'xxxxx.com' added"]},"result":null}
I hope this can be tested en solved, i gladly help where possible.
To me the issue seems related to PHP 7.2 and currently just not compatible.
Currently the Direct Admin addon only supports one PHP instance. Sometimes there are setups that use multiple PHP versions. We should be able to handle system setups that have 2 of these. The current setup uses /usr/local/bin/php
, however we should also support custom locations like /usr/local/php55
Hello,
Since DA release 1.62 our SpamExperts plugin does not work properly.
I see that in f576d6b this is fixed by @LaurentiuTeodorescu - we tried this manually and it works.
However, normally we have an "Update" button in the DA plugin interface, but the new version is not yet available there.
Can we expect it to be available soon?
Thanks!
Let's be honest, this plugin hasn't really gotten any real attention for years.
It's insecure (#22) and apart from a new logo, it's hardly maintained. Although there is an issue about verifying PHP 7 compatibility, this was never addressed. On recent versions we get deprecation errors (#19).
I would argue that this plugin needs to be rebuild from the ground up. Preferably not by ModulesGarden. Their code is often riddled with bugs and the quality of their code is low.
@dbistriceanu @LaurentiuTeodorescu @tonyandrewmeyer
Some points of attention:
It appears when 2 users have the same beginning part of the username, the domain list shows the domain from the other user with the same first part of their username. This is a data/privacy issue.
# cat available_version.txt
4.0.1490694693
bob
and add domain example.combobsfriend
and add domain example.netbob
Result shows the domain from bob
and bobsfriend
Only the domains from that user should be shown.
I must say I feel reluctant to open an issue here because it feels like SpamExperts has dropped the ball and doesn't do any development on this anymore.
This module is using __autoload which is deprecated for a while. It needs to be replaced with spl_autoload_register. This function has been deprecated for 3 (!!) years.
Use the module.
Get a deprecation notice.
No notice.
If you check a domain for protection it may return the following error message:
The domain 'domain.com' does not belong to the admin 'adminuser'
That gives away the admin user you're connecting with. It shouldn't.
Would be good to tests and adjust anything in the direct admin addon against php7. Any issues found should be fixed here.
This should still work with both php5 and php7.
DirectAdmin v.1.50.1
PHP version: 5.5.38
1.The client installed DA, with API enabled with SSL. He set public IP address of server and admin credentials in file directadminapi.conf.new, packaged file as tar.gz and installed.
He's getting an error: No Connection. Please, setup connection details in "directadminapi.conf". SSL certificate is self-signed -
When he disables SSL ssl=0 in directadminapi.conf.new then it still doesn't work and error message is the same.
whmcs #526813
4.0.1490694693
Domain is not being changed in SpamExperts, old domain stays
Domain being changed to new value
directadmin-addon/lib/DirectAdmin_API.php
Line 72 in fb2d7f9
Basing a decision on whether or not a dot is set at the end of a record and if it includes $domain
is extremely sensitive to false positives. If a user has decided to move their e-mail and only change the A records, not the MX records, this plugin will happily destroy it all. If the e-mail is hosted elsewhere there's only one setting that matters and that can be found in CMD_API_DNS_MX?domain=.
If internal
is set to yes all e-mail is handled by the server the domain is also hosted on. If it's set to no then you can be sure it's hosted elsewhere.
Unfortunately though DirectAdmin has only made this setting available to a user. As an admin user you don't have direct permissions to run this API call. The only way to get around that is to connect as the user who owns the domain and run the call as that user. You would have to create a different socket that uses set_login('admin|username', 'password'). That way you do have access to CMD_API_DNS_MX.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.