Giter VIP home page Giter VIP logo

plesk-extension's People

Contributors

alexkiro avatar claudiapetre avatar dbistriceanu avatar dependabot-preview[bot] avatar donici avatar laurentiuteodorescu avatar lorentina avatar tonyandrewmeyer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

plesk-extension's Issues

Created alias is not protected

Steps:

  1. Install and configure Professional SpamFilter extension with settings: Automatic action for a new domain when it is added to this server = Protect, Action on secondary domains (domain aliases) = Protect as Domains
  2. Create domain alias
  3. Check status

Actual result:
Created alias is not protected

Expected result:
I expect that it should be protected

Unprotected domains after removing extension

Steps:

  1. Install and configure Professional SpamFilter
  2. Protect domain
  3. Remove extension
  4. Check DNS settings

Actual result:
MX records are not changed to default
Domain is protected

Expected result:
Possibly there should be setting whether MX records should be removed and domains be unprotected

Add option for a hard-coded route

It will be useful here is there was an option to allow users, to be able to hard code a specific route directly in the settings page, that would set a specific configured route for all domains that are provisioned. This would then overrule any API/DNS checks on the domains current MX records, and only provision the domains with this configured new route.

CC:5

UI improvements to the extension configuration page

We should change the current error message to be more user friendly:

screenshot from 2017-05-05 11-04-49

This should:

  1. Not be an "error" but likely warning or info
  2. Be more informative

The descriptive text should also be removed from:

  • AntiSpam API URL
  • SpamFilter API hostname
  • SpamFilter API username
  • SpamFilter API password
  • Primary MX *
  • Secondary MX
  • Tertiary MX
  • Support email

SpamFilter API revision is rev.UNKNOWN

Version information

N/A

Steps to replicate

  1. Install and configure extension
  2. Go to 'Support' tab of extension

Actual result

In 'Diagnostics' section SpamFilter API: rev.UNKNOWN

Expected result

API version is shown.

Other notes

Make use of buy_url parameter

The meta.xml file should include a new property - buy_url that indicates where the services which the extension provides can be purchased. An example of that property usage can be found here. The property should have the following value:

https://go.plesk.com/buy-plesk-ext/spamexperts-extension

(the page is not configured yet, it will be after the new version of the extension publication)

For now the Buy URL should be used in the following scenario - when the license is not installed it's not clear there is such possibility to buy the license and use configuration parameters from it. It would be helpful to add a message on the configuration form saying that the license is not installed and the user needs to buy it in online store. To get link to online store on the extension side the pm_Context::getBuyUrl() SDK method should be used.

Provisioning error

After setting up APS, client has not creates a seperate service template for SpamExperts, they added resources to their hosted exchange 2013 service template as seen in the screenshot.

They are getting the following error:

"Service Creation Failed: Parallels Operations Automation error #error_code #0, extype_id #1, module_id #Common, Internal error: APSC: More than one resource from hosting context is applicable for relation 'email' of type 'http://aps-standard.org/types/core/service-user/1.0'...<http://aps-standard.org/types/core/service-user/1.0%27...> Service Creation Failed: Parallels Operations Automation error #error_code #0, extype_id #1, module_id #Common, Internal error: APSC: More than one resource from hosting context is applicable for relation 'email' of type 'http://aps-standard.org/types/core/service-user/1.0'...".<http://aps-standard.org/types/core/service-user/1.0%27...%22.>"

Whmcs #879007

User see only subscription domain when open extension page

Version information

N/A

Steps to replicate

  1. Create user with domain, add-on domain and subdomains
  2. Install and configure extension
  3. Login in Plesk using user credentials
  4. Click on 'Professional SpamFilter' button in right navigation bar
    NOTE: Link on button is [site]:8443/modules/spamexperts-extension/index.php/index/domain

Actual result

Extension page is opened only with subscription domain. No tab is active.
Domain type shown as 'Site'
If user click on 'Domains' tab he will see list with all his domains, add-on domains and subdomains. Now domain type is 'Webspace'!

Expected result

As user doesn't have ability to open extension for specific site - 'Domains' tab should be open by default with list of all accessible domains for user.

Other notes

Remove support form at lower levels

We should remove the support form at levels lower than the Plesk administrator that configured the extension.

Not sure how this will work with the support email form though. Likely we need to hardcode the address at that level.

Upgrade fails from APS 2.0-10 to version 2.0-15

When trying to upgrade from APS 2.0-10 to version 2.0-15 this error occurs:

Task ID
13893964
Task name
Upgrading resources of application 'SpamExperts'
Task description
Upgrading resources of application SpamExperts 2.0-10 to version 2.0-15
Belongs to groups
2699:154194302
Parent task ID
13893963
Queue status
Failed
Start not earlier than
Jan-25-2017 20:03
Method name
taskUpgradeApp2x on SCREF:SaaSManagerTasks:0
Last execution output
Internal error: APSC: Upgrade to ver. 2.0-15 : resource 399ad95e-0941-4e38-9d38-9bd9e02beea7 of type 'service' (http://aps.spamexperts.com/app/service/1.3) for APS application 'SpamExperts-2.0-15' : The operation with name 'onContextAvailable' is not found..

Aps support suggested the isue was due to the domain aciel-geomatics.com. The domain exists in SE, it shows in Odin as not protected. When trying to unprotect the domain and update the following error is seen:

Internal error: APSC: Upgrade to ver. 2.0-15 : resource 399ad95e-0941-4e38-9d38-9bd9e02beea7 of type 'service' (http://aps.spamexperts.com/app/service/1.3) for APS application 'SpamExperts-2.0-15' : Internal Server Error: Unknown method "onContextAvailabeSubscribe"..

More logs attached.

Add support for "packages"

Would be great if there was an option to add domains to SE based on the Hosting package, so that it excludes domain-only packages.
Currently its not possible to do package based. (eg like cPanel/ addon does)
This should also then work for bulk protect, to be able to bulk protect based on specific packages.

Old and new MX records for alias. Old record is not deleted

Steps:

  1. Install and configure Professional SpamFilter extension with settings:
    Automatic action for a new domain when it is added to this server = Skip
    Action on secondary domains (domain aliases) = Skip
  2. Create subscription
  3. Create domain alias (Synchronize DNS zone with the primary domain = On)
  4. Protect subscription
  5. Check MX records for alias

Actual result:
3 MX records for alias:
alias.again. MX (20) mail.simplyspamfree.com.
alias.again. MX (10) server1.aps1.simplyspamfree.com.
alias.again. MX (10) mail.alias.again.

Expected result:
Record "alias.again. MX (10) mail.alias.again." should be deleted.

Lock form inputs when "Use license parameters" checkbox is ticked

When the license is just installed and the user enables checkbox "Use license parameters" the form is still editable till it's submitted. The same is in case the user unchecked this option and he cannot edit fields till submitting the form. It would be better to add a bit of javascript to provide better UX, e.g. disable the input fields when the checkbox is ticket and enable when the checkbox is unticked dynamically.

Add support to change language

Version information

Latest

Steps to replicate

  1. Click on Manage in spamfilter button

Actual result

. Go to english versión, but my language of plesk panel is spanish version

Expected result

Redirect to the correct language version y Spam experts panels

Other notes

Also well be good idea translate the extension to spanish.

Not working

Version information

Versión: 1.2-0

Steps to replicate

try to check status or open the panel. without succesfull

Actual result

seems like the domain is not protected when it is.

Expected result

Open control panel correctly.

Other notes

Error logging into the Interface from Plesk 17 (Onyx)

When trying to log into the Interface for a domain that was already protected and was present in the interface the following error occurs:

Version information

Plesk Onyx 10

Steps to replicate

  1. Created a new webspace for a dummy domain, example.com. This webspace has no other domains associated with it.
  2. Clicked on the «Professional spamfilter» icon in the upper right in the Website administration area, and selected the domain example.com.

Actual result

Error: Parser error: Request is invalid. Error in line 3: Element 'site-id': '' is not a valid value of the atomic type 'id_type'.

The debug log shows:

 }}} [2017-01-13 11:32:56] DEBUG [extension/spamexperts-extension] Modules_SpamexpertsExtension_SpamFilter_Api::checkDomain: Result: false Response: 'ERROR: The domain \'api.antispamcloud.com\' does not belong to the admin \​'name_of_admin\'. }}}

However the domain seems to be wrong. Shouldn't this show the name of the domain that should actually be protected?

Expected result

Other notes

SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'value' cannot be null

Version information

  • Plesk Extension v1.2-0
  • Plesk Panel v12.5

Steps to replicate

  1. Install the extension
  2. Install a license for the extension
  3. Open the extension's Settings page
  4. Click on the link to use the license provided by Plesk
  5. Click on 'Save' button

Actual result

Error message appears:

Internal error.
ERROR: Zend_Db_Statement_Exception: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'value' cannot be null (Pdo.php:234)

Expected result

No error messages, like on Plesk v17.0 and Plesk v17.5.

Other notes

[2017-08-08 17:37:29] ERR [1] PleskMainDBException: DB query failed:
INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)

Error: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'value' cannot be null
file: /usr/local/psa/admin/plib/Db/Adapter/Pdo/Mysql.php
line: 30
code: 0
trace: #0 /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php(575): Db_Adapter_Pdo_Mysql->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#1 /usr/local/psa/admin/externals/Zend/Db/Table/Abstract.php(1075): Zend_Db_Adapter_Abstract->insert(string 'ModuleSettings', array)
#2 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(467): Zend_Db_Table_Abstract->insert(array)
#3 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(438): Zend_Db_Table_Row_Abstract->_doInsert()
#4 /usr/local/psa/admin/plib/Db/Table/Row.php(27): Zend_Db_Table_Row_Abstract->save()
#5 /usr/local/psa/admin/plib/pm/Settings.php(56): Db_Table_Row->save()
#6 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(506): pm_Settings::set(string 'spampanel_url', NULL null)
#7 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(75): IndexController->setSetting(string 'spampanel_url', NULL null)
#8 /usr/local/psa/admin/externals/Zend/Controller/Action.php(516): IndexController->settingsAction()
#9 /usr/local/psa/admin/externals/Zend/Controller/Dispatcher/Standard.php(295): Zend_Controller_Action->dispatch(string 'settingsAction')
#10 /usr/local/psa/admin/externals/Zend/Controller/Front.php(954): Zend_Controller_Dispatcher_Standard->dispatch(object of type Zend_Controller_Request_Http, object of type Zend_Controller_Response_Http)
#11 /usr/local/psa/admin/plib/pm/Application.php(72): Zend_Controller_Front->dispatch()
#12 /usr/local/psa/admin/htdocs/modules/spamexperts-extension/index.php(4): pm_Application->run()

[2017-08-08 17:37:30] ERR [panel] SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'value' cannot be null:
0: /usr/local/psa/admin/externals/Zend/Db/Statement/Pdo.php:234
        Zend_Db_Statement_Pdo->_execute(array)
1: /usr/local/psa/admin/externals/Zend/Db/Statement.php:300
        Zend_Db_Statement->execute(array)
2: /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php:479
        Zend_Db_Adapter_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
3: /usr/local/psa/admin/externals/Zend/Db/Adapter/Pdo/Abstract.php:238
        Zend_Db_Adapter_Pdo_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
4: /usr/local/psa/admin/plib/Db/Adapter/Pdo/Mysql.php:19
        Db_Adapter_Pdo_Mysql->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
5: /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php:575
        Zend_Db_Adapter_Abstract->insert(string 'ModuleSettings', array)
6: /usr/local/psa/admin/externals/Zend/Db/Table/Abstract.php:1075
        Zend_Db_Table_Abstract->insert(array)
7: /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php:467
        Zend_Db_Table_Row_Abstract->_doInsert()
8: /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php:438
        Zend_Db_Table_Row_Abstract->save()
9: /usr/local/psa/admin/plib/Db/Table/Row.php:27
        Db_Table_Row->save()
10: /usr/local/psa/admin/plib/pm/Settings.php:56
        pm_Settings::set(string 'spampanel_url', NULL null)
11: /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php:506
        IndexController->setSetting(string 'spampanel_url', NULL null)
12: /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php:75
        IndexController->settingsAction()
13: /usr/local/psa/admin/externals/Zend/Controller/Action.php:516
        Zend_Controller_Action->dispatch(string 'settingsAction')
14: /usr/local/psa/admin/externals/Zend/Controller/Dispatcher/Standard.php:295
        Zend_Controller_Dispatcher_Standard->dispatch(object of type Zend_Controller_Request_Http, object of type Zend_Controller_Response_Http)
15: /usr/local/psa/admin/externals/Zend/Controller/Front.php:954
        Zend_Controller_Front->dispatch()
16: /usr/local/psa/admin/plib/pm/Application.php:72
        pm_Application->run()
17: /usr/local/psa/admin/htdocs/modules/spamexperts-extension/index.php:4
[2017-08-08 17:37:30] ERR [1] Zend_Db_Statement_Exception: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'value' cannot be null
file: /usr/local/psa/admin/externals/Zend/Db/Statement/Pdo.php
line: 234
code: 23000
trace: #0 /usr/local/psa/admin/externals/Zend/Db/Statement.php(300): Zend_Db_Statement_Pdo->_execute(array)
#1 /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php(479): Zend_Db_Statement->execute(array)
#2 /usr/local/psa/admin/externals/Zend/Db/Adapter/Pdo/Abstract.php(238): Zend_Db_Adapter_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#3 /usr/local/psa/admin/plib/Db/Adapter/Pdo/Mysql.php(19): Zend_Db_Adapter_Pdo_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#4 /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php(575): Db_Adapter_Pdo_Mysql->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#5 /usr/local/psa/admin/externals/Zend/Db/Table/Abstract.php(1075): Zend_Db_Adapter_Abstract->insert(string 'ModuleSettings', array)
#6 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(467): Zend_Db_Table_Abstract->insert(array)
#7 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(438): Zend_Db_Table_Row_Abstract->_doInsert()
#8 /usr/local/psa/admin/plib/Db/Table/Row.php(27): Zend_Db_Table_Row_Abstract->save()
#9 /usr/local/psa/admin/plib/pm/Settings.php(56): Db_Table_Row->save()
#10 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(506): pm_Settings::set(string 'spampanel_url', NULL null)
#11 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(75): IndexController->setSetting(string 'spampanel_url', NULL null)
#12 /usr/local/psa/admin/externals/Zend/Controller/Action.php(516): IndexController->settingsAction()
#13 /usr/local/psa/admin/externals/Zend/Controller/Dispatcher/Standard.php(295): Zend_Controller_Action->dispatch(string 'settingsAction')
#14 /usr/local/psa/admin/externals/Zend/Controller/Front.php(954): Zend_Controller_Dispatcher_Standard->dispatch(object of type Zend_Controller_Request_Http, object of type Zend_Controller_Response_Http)
#15 /usr/local/psa/admin/plib/pm/Application.php(72): Zend_Controller_Front->dispatch()
#16 /usr/local/psa/admin/htdocs/modules/spamexperts-extension/index.php(4): pm_Application->run()
--
#0 /usr/local/psa/admin/externals/Zend/Db/Statement/Pdo.php(228): PDOStatement->execute(array)
#1 /usr/local/psa/admin/externals/Zend/Db/Statement.php(300): Zend_Db_Statement_Pdo->_execute(array)
#2 /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php(479): Zend_Db_Statement->execute(array)
#3 /usr/local/psa/admin/externals/Zend/Db/Adapter/Pdo/Abstract.php(238): Zend_Db_Adapter_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#4 /usr/local/psa/admin/plib/Db/Adapter/Pdo/Mysql.php(19): Zend_Db_Adapter_Pdo_Abstract->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#5 /usr/local/psa/admin/externals/Zend/Db/Adapter/Abstract.php(575): Db_Adapter_Pdo_Mysql->query(string 'INSERT INTO `ModuleSettings` (`module_id`, `name`, `value`) VALUES (?, ?, ?)', array)
#6 /usr/local/psa/admin/externals/Zend/Db/Table/Abstract.php(1075): Zend_Db_Adapter_Abstract->insert(string 'ModuleSettings', array)
#7 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(467): Zend_Db_Table_Abstract->insert(array)
#8 /usr/local/psa/admin/externals/Zend/Db/Table/Row/Abstract.php(438): Zend_Db_Table_Row_Abstract->_doInsert()
#9 /usr/local/psa/admin/plib/Db/Table/Row.php(27): Zend_Db_Table_Row_Abstract->save()
#10 /usr/local/psa/admin/plib/pm/Settings.php(56): Db_Table_Row->save()
#11 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(506): pm_Settings::set(string 'spampanel_url', NULL null)
#12 /usr/local/psa/admin/plib/modules/spamexperts-extension/controllers/IndexController.php(75): IndexController->setSetting(string 'spampanel_url', NULL null)
#13 /usr/local/psa/admin/externals/Zend/Controller/Action.php(516): IndexController->settingsAction()
#14 /usr/local/psa/admin/externals/Zend/Controller/Dispatcher/Standard.php(295): Zend_Controller_Action->dispatch(string 'settingsAction')
#15 /usr/local/psa/admin/externals/Zend/Controller/Front.php(954): Zend_Controller_Dispatcher_Standard->dispatch(object of type Zend_Controller_Request_Http, object of type Zend_Controller_Response_Http)
#16 /usr/local/psa/admin/plib/pm/Application.php(72): Zend_Controller_Front->dispatch()
#17 /usr/local/psa/admin/htdocs/modules/spamexperts-extension/index.php(4): pm_Application->run()

Plesk extension not removing old MX record

Version information

Plesk: v17.0.17 (Unix)
Extension version: v1.1-0

Steps to replicate

  1. Add new domain to the latest Plesk Extension
  2. Once you did so, the domain will be uploaded to the SpamExperts interface and the new MX records will be added
  3. However, the old MX records will still be there

Actual result

The old MX records are not removed

Expected result

The domains should only have the new MX records added

Other notes

Protect alias if setting "Action on secondary domains (domain aliases)" is Skip

Steps:

  1. Create domain. Protect it.
  2. SpamExpert settings see in attach
  3. Create domain alas with "Synchronize DNS zone with the primary domain" = OFF

Actual result:
Alias is absent in Domains list.
DNS Settings for alias are protected:

sync.no. MX (20) mail.simplyspamfree.com.
sync.no. MX (10) server1.aps1.simplyspamfree.com.

Expected result:
Alias is not protected because setting "Action on secondary domains (domain aliases)" is Skip

Add Support for optionally protecting sub-domains

Version information

N/A

Steps to replicate

  1. Configured Extension
  2. Add Domain
  3. Add Sub-domain

Actual result

both Domain and Sub-domain are added as protected domains.

Expected result

You should be able to specify the action for Sub-domains, including not protecting, adding as alias or as a domain.

Other notes

Add support for the Archiving service

As Archive module support was not a requirement for the module development at the time it was created, one of our clients would like to have this option available.

why configuring MX records under setup instead of destination host entries?

another question is why those fields are names "primary MX" and "secondary MX" because those settings are controlled via DNS and are pointing towards the spamexperts incoming IP and not the end mailserver. should'nt be those fields called "primary destination host" and "secondary destination host"?

Update metadata for extensions catalog

As per Marilena reques the title and the description need to be updated to the following values:

Title

SpamExperts Email Security

Description

The application integrates SpamExperts' advanced email security system with Plesk, offering automatic protection of domains and emails as well as a one-click login option to the dedicated SpamExperts control panel to manage specific settings and view detailed statistics.

Provisioning fails if the default MX records are deleted from spampanel.options for reseller_id=0

Version information

ebd9172

Steps to replicate

  1. Use a valid plesk license to configure the extension
  2. Add a new domain
  3. Protect the domain

Actual result

SpamFilter MX hostnames are not set

Expected result

The domain should be protected

Other notes

 <get>
  <filter>
   <site-id>1</site-id>
  </filter>
 </get>
</dns>
[2017-08-28 12:44:26] DEBUG [panel] run operator
[2017-08-28 12:44:26] DEBUG [extension/spamexperts-extension] Request is finished, response is: <?xml version="1.0" encoding="UTF-8"?>
<packet version="1.6.7.0"><dns><get><result><status>ok</status><site-id>1</site-id><zone_type>master</zone_type><zone_status>enabled</zone_status></result></get></dns></packet>

[2017-08-28 12:44:26] DEBUG [extension/spamexperts-extension] Modules_SpamexpertsExtension_SpamFilter_Api::checkDomain: Domain protection check request
[2017-08-28 12:44:26] INFO [extension/spamexperts-extension] Making SpamFilter API request: /api/domain/exists/domain/example.net
[2017-08-28 12:44:27] INFO [extension/spamexperts-extension] SpamFilter API response: ERROR: The domain 'example.net' does not belong to the admin 'plesk_04343131_1'.```

Add support for PHP 7

In the future release of the Plesk control panel, the PHP version used will be 7.1. There is no release date set for the new Plesk version, however we should ensure compatibility beforehand.

Changelog can be found here. The new Plesk version is still in "Preview" at this point.

File hashes verification

Like the cPanel add-on does, our Plesk extension should also provide the ability to verify file hashes as a part of the diagnostic procedure (the Support tab) to make sure that none of the extension scripts have been changed.

The existing implementation can be ported to work as a part of the extension. The ​CLI interface abilities should be enough to make such task possible.

Newly added subdomain was protected automatically with time lag

Steps:

  1. Install and configure Professional SpamFilter extension with settings: Automatic action for a new domain when it is added to this server = Protect, Action on the MX records for protected/unprotected domains = Update
  2. Create new subscription
  3. Go to Plesk - Subscriptions - - Add Subdomain and create subdomain
  4. Go to Plesk - Extensions - Professional SpamFilter, select subdomain and click "Check Status"
  5. Wait ~2-5 min
  6. Go to Plesk - Extensions - Professional SpamFilter, select subdomain and click "Check Status"
  7. Go to Plesk - Domain - - DNS settings and click "Enable"

Actual result:
Step 4: "Domain '' is NOT protected"
Step 6: "Domain '' is protected"
Step 7: Only one MX record is present:
. MX (10) mail..

Expected result:
Step 4: "Domain '' is protected"
Step 7: Appropriate MX records are present:
. MX (20) mail.simplyspamfree.com.
. MX (10) server1.aps1.simplyspamfree.com.

Additional info:
Such a behavior can be reproduced only for subdomains.
Newly added domains and aliases were protected automatically without such a time lag. Appropriate MX records were created for newly added domains and aliases. Possible this issue is somehow caused with last fix when sleep() was added.

Support form improvement

Version information

N/A

Steps to replicate

When their clients try to submit a request to our support, they see the following notification: Professional Spam filter Information: Your message has been queued for delivery. Customer assumes this happens because they have port 25 blocked by Cloud provider or ISP.

Actual result

Nothing happens and our support mail / ticketing system does not receive the message. There is also no auto-reply to the email specified in "Reply-To" with the ticket ID

Expected result

Create a support request in our support mail / ticketing system which should land in the proper queue

Other notes

Additional information from customer side:

  1. Implement a mechanism for ticket submitting, which would avoid issues with port 25.

  2. Improve the output, so that from our side it shows that a request has been sent only if it was sent indeed. And shows errors if it wasn’t.

Primary contact email is NOT set for subdomains

Steps:

  1. Install and configure Professional SpamFilter extension with settings:
    Automatic action for a new domain when it is added to this server = Protect
    Action on the MX records for protected/unprotected domains = Update
    Primary contact email for protected domains = Set
    Action on "remote" domains (hosted on external DNS servers) = Protect
  2. Create protected subdomain
  3. Open SpamExpert control panel

Actual result:
Primary contact email is NOT set for subdomains

Expected result:
Primary contact email is set for subdomains

Wrong debug log when license is valid

It seems that a wrong debug log is added in the panel.log when the Plesk license is valid and not added when the license is expired.

if (date('Ymd') < $licenseMeta['lim_date']) {
    pm_Log::debug("Do not use Plesk license data is the license seems to be expired");
}

MX records are not changed for subdomain

Steps:

  1. Install and configure Professional SpamFilter extension with settings:
    Action on "remote" domains (hosted on external DNS servers = Protect
    Automatic action for a new domain when it is added to this server = Protect
    Action upon SpamFilter panel login to not protected domain = Report error
  2. Create protected domain
  3. Create subdomain
  4. Check status
  5. Enable DNS Settings
  6. Check status and DNS records

Actual result:
Step 4. Subdomain is protected
Step 6. Subdomain is protected and DNS records:
protparent.example.test. MX (10) mail.protparent.sveta.test.

Expected result:
Step 6. Subdomain is NOT protected or DNS records:
protparent.example.test. MX (20) mail.simplyspamfree.com.
protparent.example.test. MX (10) server1.aps1.simplyspamfree.com.

Account migration form implementation

It not possible to just change a Spampanel account details which is used for the extension-to-Spampanel API connection as due to security reasons the new account will not get access to all entities added by the previous one. Thus a special page - Migration - is required for the purpose of changing the operational account.

It should work exactly as it does in the cPanel added.

wrong destination host entries. it does not take the entries from setup

at the extension under settings there are the parameters "primary MX" and "secondary MX" entries. at the old extension for plesk 12.5 we filled in there our destination mail host name. lets say our antispam has the name nospam1.yourdomain.com and the mailserver ( destination host ) has mail.yourdomain.com. so we filled in at the primary MX inside the extension/settings register "mail.yourdomain.com". when we now setup a new domain this was taken a the destination host inside the spamexperts servers config for that domain. that was working. but now we can enter whatever we want it does not take those names. but instead i tries to choose as destination hostnames the MX DNS Records which is wrong because that would be the spamexperts incoming filter itselve!!

SpamExperts extension not working with Plesk 17 (Onyx)

When domain list is viewed, the list remains empty. "There are no domains on this server."

PHP version:
OK!
PHP extensions:
OK!
Configuration permissions:
OK!
Panel version:
OK!
Addon version:
OK!
Hashes:
OK!
Hooks:
OK!
Symlinks:
OK!
Controlpanel API:
Unable to communicate with the controlpanel API
CRITICAL
Spamfilter API:
OK!
Symlink to PHP5 binary:
OK!

Add a status column to the domain list

We should add a status column to the domain list in the "Domains" tab instead of having alerts for each domain, as those can stack up a lot for large number of domains. (This should likely work the same as we have in the cPanel addon)
screenshot from 2017-05-05 11-09-23

Original MX record not removed after the domain is added

Version information

Plesk Version: Version 17.8.11
Extension Version: Version: 1.2-0
OS Version: CloudLinux 7.5
Kernel Version: 3.10.0-714.10.2.lve1.5.17.1.el7.x86_64

Steps to replicate

  1. Add a domain
  2. The domain is added correctly, the MX records are added but the original MX record is not removed

Actual result

the original MX record is not removed

Expected result

For the original MX record to be removed and only the filtering server's MX records to be kept

Other notes

Credentials are overwritten when a domain is migrated

Version information

Plesk Onyx
Plesk: v17.0.17 (Unix)
PHP version: 5.6.27
Extension version: v1.1-0

Steps to replicate

Did not check if this replicates

  1. Install extension on one Plesk server (server1)
  2. Install extension on one Plesk server (server2)
  3. Configure server1 extension with a user (user1)
  4. Configure server2 extension with a user (user2)
  5. Add domain on server1
  6. Use Plesk migrator to migrate domain from server1 to server2
  7. Check extension settings on server2.

Actual result

Using the Plesk migrator to move one domain between servers, the general SpamExperts module configuration is also migrated, so the main user and password configured in the module to access to their spamexperts local cloud is overwritten on the destination node.

Expected result

This should not be happening, from the client's perspective.

Other notes

Whmcs #156235

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.