sparkplug / momoapi-php Goto Github PK

[RuntimeException]
No composer.json present in the current directory, this may be the cause of the following exception.

[InvalidArgumentException]
Could not find a version of package sparkplug/momoapi-php matching your minimum-stability (stable). Require it with
an explicit version constraint allowing its desired stability.

require [--dev] [--prefer-source] [--prefer-dist] [--fixed] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--update-with-all-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] []...

We shall need to change the package name to mtn-momo to ensure naming consistency across the different ecosystems.

This library doesn't currently support the Remittances API. We need to add a module to support remittances. It should support the following operations:

• POST /token (we need to add an authorizer for this)
• POST /transfer
• GET /transfer/{referenceId}
• GET /v1_0/account/balance
• GET /v1_0/accountholder/{accountHolderIdType}/{accountHolderId}/active

Reference

• https://momodeveloper.mtn.com/docs/services/remittance

Need to add a contributing guide

Problem

Most of the code currently in master is not tested. This means it will be hard to detect when this library starts to fail.

Solution

To ensure that the library behaves as expected, we need to add tests.

Tasks

• setup testing suite
• add unit tests for collections, disbursements, remittances
• add unit tests for users

how do I get API user and password from Momopay live / production environment

Is your feature request related to a problem? Please describe.

The library needs to throw custom errors depending on what errors are returned by MTN

Describe the solution you'd like

We should add custom error classes and throw them when the corresponding error occurs

Tasks

• Add error classes for all possible MTN errors
• Throw the correct exceptions depending on errors that occur

Is your feature request related to a problem? Please describe.

Currently, we don't have any validation to ensure users are invoking functions with the right parameters. The only validation we get is from the API. Ideally, we should identify errors and fail fast before they reach the API

Describe the solution you'd like

We need to add assertions on functions and constructors to ensure that the correct information is being given.

We need to add CI to facilitate automation of testing and publishing. We shall use Travis CI.
For the start, the CI should publish to Composer when a PR is reviewed and merged to master.

Progress

• configure pylint
• configure testing
• configure semantic versioning
• configure travis ci
• add appropriate Composer token and github token to Travis CI secrets

Some of the variables required to initialize the library are global, while others are product specific.

The global variables are;

• Base URL (Sandbox or Production URL)
• Platform Environment (Sandbox or Production)
• Callback Host

The product specific ones are;

• Subscription Key (Primary or Secondary)
• User ID
• User/API Secret

Describe the solution you'd like

We should initialize the library with global variables and then initialize the product clients with product-specific variables.

The client does not fully support the Collections API. We need to add a module to support the following operations:

• POST /token (we need to already have an authorizer for this)
• POST /requesttopay
• GET /requesttopay/{referenceId}
• GET /v1_0/account/balance
• GET /v1_0/accountholder/{accountHolderIdType}/{accountHolderId}/active

Reference

• https://momodeveloper.mtn.com/docs/services/collection

The library does not fully support the Disbursements API. We need to add a module to support disbursements. The module must support the following operations:

• POST /token (we need to create an authorizer for this)
• POST /transfer
• GET /transfer/{referenceId}
• GET /v1_0/account/balance
• GET /v1_0/accountholder/{accountHolderIdType}/{accountHolderId}/active

Reference

• https://momodeveloper.mtn.com/docs/services/disbursement

The README needs to be updated to reflect the changes that are being made and will be made in the production library.