Comments (6)
Here is a trait, that is a possible solution for the problem:
<?php
namespace App\Nova\Traits;
trait SortTranslatableFields
{
protected static function applyOrderings($query, array $orderings)
{
$locale = app()->getLocale();
$translatableAttributes = app(self::$model)->make()->getTranslatableAttributes();
foreach ($orderings as $column => $direction) {
if (in_array($column, $translatableAttributes)) {
unset($orderings[$column]);
$query->orderByRaw("`{$column}` -> '$.{$locale}' {$direction}");
}
}
return parent::applyOrderings($query, $orderings);
}
}
Maybe this Trait could be added to the package, but you have to manually "use" it in every Nova resource, where you use Translatable fields.
from nova-translatable.
I made a macro. That way I can set it once and forget about it.
use Spatie\Translatable\HasTranslations;
use Illuminate\Database\Eloquent\Builder;
Builder::macro('orderBy', function ($field, $order = 'asc', $locale = null) {
if (
in_array(HasTranslations::class, class_uses($this->model))
&& in_array($field, $this->model->translatable)
) {
$locale = $locale ?? app()->getLocale();
$field .= '->' . $locale;
$this->query->orderBy($field, $order);
} else {
$this->query->orderBy($field, $order);
}
return $this;
});
from nova-translatable.
Feel free to send a PR that fixes this
from nova-translatable.
I think this has nothing to do with this package, the problem is how Nova handles the underlying json columns when sorting / searching.
MySQL isn't able to sort based on json column values with a simple ORDER BY column_name ASC/DESC
.
The query should look something like this to work properly:
ORDER BY `column` -> '$."en"' DESC
from nova-translatable.
Closing this as it can't be handled in the package.
from nova-translatable.
Here is a trait, that is a possible solution for the problem:
<?php namespace App\Nova\Traits; trait SortTranslatableFields { protected static function applyOrderings($query, array $orderings) { $locale = app()->getLocale(); $translatableAttributes = app(self::$model)->make()->getTranslatableAttributes(); foreach ($orderings as $column => $direction) { if (in_array($column, $translatableAttributes)) { unset($orderings[$column]); $query->orderByRaw("`{$column}` -> '$.{$locale}' {$direction}"); } } return parent::applyOrderings($query, $orderings); } }
Maybe this Trait could be added to the package, but you have to manually "use" it in every Nova resource, where you use Translatable fields.
For those who land here, trying to go the Trait way, on PostgreSQL, here is the syntax to access your JSON fields:
$query->orderByRaw("{$column}->>'{$locale}' {$direction}");
You may have to play with -> and ->> after the column name, or cast to string after accessing with ->
from nova-translatable.
Related Issues (20)
- Forced Trix field attachments
- Nova Markdown field preview fails HOT 1
- Nova Repeater field
- Different rules for each translation HOT 3
- Slug field loses functionality when using Translatable
- support spatie/laravel-translatable 6 HOT 1
- Make only one locale required HOT 1
- Nova 4 support
- Nova 4 Slug field Bug HOT 1
- Field -> displayUsing does not work HOT 1
- src/Translatable.php:233 - onIndexPage() throws error when there is no controller on the action HOT 1
- PHP 8.2 : Deprecation warning on creation of dynamic properties HOT 1
- Combining translatable with images in a Trix field does not work
- Adding Translatable to new Panel doesn't work HOT 7
- Maintenance of Nova 3 support HOT 9
- Name field shows as row JSON HOT 2
- Deprecation warning for dynamic property HOT 1
- KeyValue Field HOT 1
- Problem in combination with a Slug field
- Nova Markdown File upload
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nova-translatable.