Giter VIP home page Giter VIP logo

Comments (8)

freekmurze avatar freekmurze commented on May 22, 2024 1

@Jamesking56 🎉

from opening-hours.

freekmurze avatar freekmurze commented on May 22, 2024 1

@Jamesking56 Thank you for your offer but we decided to pick @kylekatarnls as the maintainer.

@kylekatarnls Thank you for all the nice work you to at Carbon, we love that package at Spatie. 👍

I'll give you edit rights on this repo. Feel free to respond to issues, merge PRs and tag new releases. When you should want to tag a major new release, prepare it on a new branch, let us know, so we can review it.

If you have any questions ping me or @sebastiandedeyne (freekmurze and sebdedeyne on Twitter).

Thank you for stepping up!

from opening-hours.

Jamesking56 avatar Jamesking56 commented on May 22, 2024

I'd be happy to, I'll send you an email 👍

from opening-hours.

bosunski avatar bosunski commented on May 22, 2024

Will send you an email too 😅

from opening-hours.

rsm23 avatar rsm23 commented on May 22, 2024

Will do

from opening-hours.

Jamesking56 avatar Jamesking56 commented on May 22, 2024

@freekmurze To allieviate you from this package, I am willing for my company @momentumstudi0 to take on this package in the form of a fork with a separate composer package momentumstudio/opening-hours.

Is this something that would be better for you and all the users of this package? With this one publishing as abandoned forwarding to momentumstudio/opening-hours?

We have a fork now, but not published to composer yet, awaiting your approval.

from opening-hours.

kylekatarnls avatar kylekatarnls commented on May 22, 2024

Hi,

I maintain among others https://github.com/briannesbitt/Carbon and https://github.com/kylekatarnls/business-time (that uses spatie/opening-hours)

Right now, business-time uses a work-around to fix #73, enable DateTimeImmutable and support wrappers such as Carbon.

Regarding commits and issues frequency, it does not seems opening-hours need big refactoring, so an ownership transfer seems not justified to me. I agree to help (answer/reviews/bug fixes/tag) but I would feel more confortable doing it on the original project than on a fork.

I will need #75 to drop the work-around on business-time but I would prefer to just update to spatie/opening-hours to ^2 than using an other project or fork it then get potential namespace conflict if different versions of the library would fall in the same project. We should really avoid to explode the project into multiple forks. First, because it seems fair to me spatie would keep the ownership on the project even if it's maintained by other developers. Then to keep a unique reference providing a consistent common support.

from opening-hours.

sebastiandedeyne avatar sebastiandedeyne commented on May 22, 2024

@kylekatarnls A huge thanks for helping out here!

from opening-hours.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.