spaze / letsgetacert Goto Github PK

Change EXPIRY_THRESHOLD=5 to 30 in README to match Let's Encrypt's own recommendation.

Since release 1.6.0, Certbot can use scoped API Tokens for Cloudflare DNS plugin (docs updated in certbot/certbot#8015), not needing the Global API Key, or have access to other zones.

Currently, letsgetacert's docs mentions CERTBOT_DNS_CHALLENGE_OPTS (added in #3) can be used in the global config file but it also can be used in the cert conf file, which now makes more sense because each token is valid for different domain so if letsgetacert manages multiple domains, you'll have multiple tokens.

The docs should reflect that.

OpenSSL 1.1.1 has added a new option to req to specify SAN (openssl/openssl#3311):

-addext "subjectAltName = DNS:foo.co.uk" \

Let's use that instead of creating a new temp file when OpenSSL 1.1.1 is used.

Currently, the key (specified by PRIVKEY) is required to exist. That's because I wanted to reuse the key because HPKP. HPKP is now being phased out so we can stop requiring the key and can generate it ourselves every time the cert is renewed. It should be possible to specify the key type (RSA/EC).

When using certbot-auto and plugins (e.g. Cloudflare DNS plugin), when a new certbot version is released, the environment gets refreshed and the plugin needs to be installed again with something like:

sudo -H /opt/eff.org/certbot/venv/bin/pip install certbot-dns-cloudflare

There should be an option to run this automatically before renewing certs.

Certbot itself supports some hooks when running in manual mode (not used here), or when renew command is used (not used either).

One could use something like this in letsgetacert.cnf:

CERTBOT=pip install certbot-dns-cloudflare && /opt/certbot/certbot-auto

but it looks weird. This should be handled nicely somehow.