Comments (2)
The PION_LOG_* macros are just redefinitions of other macros used by , and the standard used by Boost libraries is that macros are all uppercase. It sounds like what you have in mind is some new class that uses inlines to wrap the macros. I agree this might make the code look cleaner, but it would also be a rather disruptive change -- maybe not so much in substance, but the diffs would be pretty big. I'd prefer not to try doing this right now.
At some point down the road I would like to try merging in support for . I know there were some proposals for that a few years ago but not sure what became of them. That might be a better time to try refactoring the logging code.
from pion.
Ok. In the end I also could have that classes at my side. Closing this issue.
from pion.
Related Issues (20)
- Add a clang-format file and document approved clang-format version
- Contributors agreement submission form seems broken HOT 3
- Add support for HTTP2 HOT 1
- Quoted boundaries doesn't work
- Win32 : LNK2001 HOT 1
- Multiple COOKIE headers are not allowed by RFC 6265
- Mismatch between finished_handler_t and the actual handler function
- Another pion release including bugfixes from HEAD from the last months?
- FindLog4cplus.cmake broken HOT 5
- Service headers are not getting installed when built using CMake
- Allow *some* access to currently registered resources
- Compilation issue in pion/include/pion/tcp/connection.hpp
- Ability to disable OpenSSL support (CMake)
- libpion.so dependency on boost test framework HOT 2
- Feature Request:(?) overload writer::send_chunk(void) HOT 1
- Support boost 1.66 HOT 3
- configure: error: Unable to link with the boost::unit_test_framework library HOT 3
- pion.http.server logger name does not work with log4cplus HOT 1
- compiling and running with boost 1.70.0 HOT 5
- Code and Roadmap for PION HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pion.