https://www.linkedin.com/feed/update/urn:li:activity:7032347151833661441?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7032347151833661441%2C7032410578979610624%29

maybe option also to override this

improve this line
https://github.com/marianfoo/ui5-cc-excelUpload/blob/27572e52082d63f85b2fb67936069eb4b94dca39/src/controller/ExcelUpload.ts#LL75C4-L75C74

let tables = domRef.querySelectorAll("[id$='::LineItem-innerTable']");

maybe with something like this

sap.ui.core.Element.registry.filter(function(element){
    if(element.isA("sap.m.Table")){
        console.log(element.isActive())
        return element
    }
})

or

 this.test = sap.ui.getCore().byId("ui5.isu.msb.createmeterread::RunObjectPage").findElements(true).filter(function(element){
    if(element.isA("sap.m.Table")){
        console.log(element.isActive())
        return element
    }
})

Requirement

the module should be able to be deployed in a FLP context with multiple versions on a single app.
As in:

• App1 --> ui5-excelUpload v0.1.0
• App2 --> ui5-excelUpload v0.2.5
• App3 --> ui5-excelUpload v0.1.1
• App4 --> ui5-excelUpload v0.1.0

Challenge

The problem is currently that the namespaces in the FLP collide.
That means when a user calls App1 the module is called with v0.1.0 and the namespace thirdparty.customControl.excelUpload.
If the user calls App1 afterwards the module will not be loaded again because the namespace is the same.
That means the modules should be in the namespace of the app.
The ui5-tooling-modules for example does this with the parameter addToNamespace but only with non-ui5 modules.

read out the metadata what mandatory fields are (i.e. from RAP CAP Annotations)
Check if these fields are present

A dedicated Button Control which can be added to XML Views

Summary

Errors per input

Errors in docs/pages/Checks.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/docs/Events | Failed: Cannot find file

Full Github Actions output

Like at
https://github.com/SAP-samples/btp-setup-automator/blob/077a759e519ca428f471b1684840694962af28a5/README.md?plain=1#L65

don´t like throwing of error message
https://github.com/marianfoo/ui5-cc-excelUpload/blob/d07468833e292392f70a8fcd3ed2d95c473ef216/src/controller/ExcelUpload.ts#L209

if any other error thrown, the error dialog ist still shown
https://github.com/marianfoo/ui5-cc-excelUpload/blob/d07468833e292392f70a8fcd3ed2d95c473ef216/src/controller/ExcelUpload.ts#L216

https://github.com/ui5-community/wdi5/blob/e80e162c1608abd3e385768a35b2ae9eed4c70c2/.github/workflows/gh-release.yml

Some Apps already have error handling like OData V4 FE
Could be a MessageHandler available
Maybe offer option to show errors/handle error by excelUpload or handle Errors by Developer

show how many rows
maybe preview as tableview

Able to use this in a Object Page and List Report with V2/V4

• Using in List Report V2
• Using in List Report V4
• Using in Object Page V2
• Using in Object Page V4
• Using in Freestyle V2
• Using in Freestyle V4
• Using in Non Draft V2
• Using in Flexible Programming Model
• add option to always activate drafts when possible
• write doc

https://ui5.sap.com/#/topic/8521ad1955f340f9a6207d615c88d7fd

If you have defined a columns option do check only for them

from v0.9.1 to v0_9_1

Summary

Errors per input

Errors in docs/pages/SupportVersions.md

• [404] https://github.com/marianfoo/ui5-cc-excelUpload/blob/main/examples/packages/ordersv2freestyle/webapp/controller/List.controller.js | Failed: Network error: Not Found

Full Github Actions output

first check if this is actually helpful and possible

• need rewrite for csv files #33
• test for xls files

Apps

• Fiori Elements V2 List Report Draft
• Fiori Elements V2 Object Page Draft
• Fiori Elements V2 List Report Non Draft
• Fiori Elements V2 Object Page Non Draft
• Freestyle V2 Non Draft
• Freestyle V2 Non Draft Button Control
• Freestyle V2 Non Draft Button Control Standalone
• Freestyle V2 Draft
• Freestyle V2 Non Draft OpenUI5
• Fiori Elements V4 List Report
• Fiori Elements V4 Object Page
• Fiori Elements V4 Typescript
• Freestyle V4
• FPM V4

wdi5 tests

• Fiori Elements V2 List Report Draft
• Fiori Elements V2 Object Page Draft
• Fiori Elements V2 List Report Non Draft
• Fiori Elements V2 Object Page Non Draft
• Freestyle V2 Non Draft
• Freestyle V2 Non Draft Button Control
• Freestyle V2 Non Draft Button Control Standalone
• Freestyle V2 Draft
• Freestyle V2 Non Draft OpenUI5
• Fiori Elements V4 List Report
• Fiori Elements V4 Object Page
• Fiori Elements V4 Typescript
• Freestyle V4
• FPM V4

Summary

Errors per input

Errors in packages/ui5-cc-excelUpload-Button/CHANGELOG.md

• [404] ui5-cc-excelupload-button-v0.0.2...ui5-cc-excelupload-button-v0.0.3 | Failed: Network error: Not Found

Errors in docs/pages/Events.md

• [404] https://github.com/marianfoo/ui5-cc-excelUpload-sampleapp/blob/744f008b1b052a3df5594215d8d11811a8e646b7/packages/orders/webapp/ext/ObjectPageExtController.js#L47-L54 | Failed: Network error: Not Found

Errors in packages/ui5-cc-excelUpload-Generator/CHANGELOG.md

• [404] generator-ui5-excelupload-v0.2.3...generator-ui5-excelupload-v0.2.4 | Failed: Network error: Not Found

Errors in packages/ui5-cc-excelUpload/CHANGELOG.md

• [404] ui5-cc-excelupload-v0.12.0...ui5-cc-excelupload-v0.12.1 | Failed: Network error: Not Found

Full Github Actions output

to avoid errors, check for duplicat label names

refer to #29
also the two fieldMatchTypes

Currently, the data types expected are those specified by the metadata.
However, it is possible that other data types are transferred which lead to error in code or in backend.
No error message is shown currently.
Possible Datatypes to check:

• Integer
  • could be string -> convert
  • could be double --> error
• Double
  • could be string -> convert
  • could be integer
• Dates/Timestamp
  • is always a integer
  • check if after parsing is valid date
  • DO NOT try to parse a string, too many options, maybe offer option to parse by dev

May be check while parsing data.

https://github.com/marianfoo/ui5-cc-excelUpload/blob/d07468833e292392f70a8fcd3ed2d95c473ef216/src/controller/ExcelUpload.ts#L521-L553

Other (more complicated option) is to check the datatypes provided by SheetJS
https://docs.sheetjs.com/docs/csf/cell/

Need to inform user about wrong data type

Lot of options are available at design time to the developer
It should be also possible to define which options the user can set at run time
Rewrite in Controller and a new fragment needed

see #26 and #33

improve documentation
how to parse values?

@deprecated
(since 1.95) - Please use sap.ui.core.Component.create Component.create instead.

In have added excel upload function to List Report page.
The controller code is below and "batchSize" is set to 1, meaning that each record is to be sent in a separate batch.

                this.excelUpload = await this._controller.getAppComponent().createComponent({
                    usage: "excelUpload",
                    async: true,
                    componentData: {
                        context: this,
                        activateDraft: true,
                        columns: ["description", "customer_ID"],
                        mandatoryFields: ["customer_ID"],
                        batchSize: 1
                    }
                })

For the first record, draft activation is successful. However, for the second record draft activation fails.

In _getActionName method, oContext.getModel() returns undefined for the second record.

In have added excel upload function to List Report page.
The controller code is below and "activateDraft" is set to false.

                this.excelUpload = await this._controller.getAppComponent().createComponent({
                    usage: "excelUpload",
                    async: true,
                    componentData: {
                        context: this,
                        activateDraft: false,
                        columns: ["description", "customer_ID"],
                        mandatoryFields: ["customer_ID"],
                        batchSize: 0
                    }
                })

When I uploaded a file, records got activated. So, it seems activateDraft property is not checked.

For large files batch requests need to be send every 1.000 requests, otherwise there will be a out-of-memory error

Hello,

I have a problem when deploying to my on-promise environment.

On the first attempt (deploy new) it generates the app normally, but on subsequent attempts it returns this error:

I redid all the configurations... even before this version, it was working normally.

If anyone can help me I would be very grateful!

error Message or Warning
Error Message when no columns found at all

https://github.com/lycheeverse/lychee-action
https://github.com/SAP-samples/btp-setup-automator/blob/main/.github/workflows/links-watcher-cron.yml

after refactor to typescript, not every file is loaded from component-preload.js

Summary

Errors per input

Errors in docs/pages/GettingStarted.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/Generator | Failed: Cannot find file
• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/CentralDeployment | Failed: Cannot find file

Errors in docs/pages/CentralDeployment.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/GettingStarted | Failed: Cannot find file

Errors in examples/README.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/examples/LICENSE | Failed: Cannot find file

Errors in docs/pages/Development/wdi5.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/Development/GitHubActions | Failed: Cannot find file

Errors in docs/pages/GettingStartedTEMPLATE.md

• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/CentralDeployment | Failed: Cannot find file
• [ERR] file:///home/runner/work/ui5-cc-excelUpload/ui5-cc-excelUpload/pages/Generator | Failed: Cannot find file

Full Github Actions output