startup instructions not working with elixir 1.6 about kaffe HOT 7 CLOSED

Supervisor.Spec was soft deprecated in Elixir 1.5.

Should the Docs be changed to reflect the new recommended behaviour?

defmodule SAample.Application do
  @moduledoc false

  use Application
  require Logger

  def start(_type, _args) do
    children = [
      %{
        id: Kaffe.GroupMemberSupervisor,
        start: {Kaffe.GroupMemberSupervisor, :start_link, []},
        type: :supervisor
      }
    ]

    opts = [strategy: :one_for_one, name: Sample.Supervisor]
    Supervisor.start_link(children, opts)
  end
end

from kaffe.

@stevehebert What behavior are you observing?

from kaffe.

It was my fault. In the line mentioning supervisor(Kaffe.GroupMemberSupervisor, []), I didn't have the #import Supervisor.Spec directive in my .Application. This caused a ** (CompileError) lib/nurburgring/application.ex:16: undefined function supervisor/2 error on compilation.

Not something a seasoned elixir programmer would have run into, but I enjoy and appreciate how accessible and understandable your library is for someone familiar with kafka in other langauges.

from kaffe.

If I were going to change the documentation, I would add that as a reminder. Not sure how everyone feels about such a thing - otherwise we can just close this issue.

Thanks for listening.

from kaffe.

@stevehebert That's good feedback. Very small addition that would really clarify how to start a consumer. 👍

from kaffe.

@gerbal yes that could be a docs update we make.

@objectuser also wondering whether it's worth starting it this way or providing the child spec or is that supported in Elixir < 1.6?

from kaffe.

I think the docs update would be nice until we get to doing the child spec (which is a good idea).

from kaffe.