Giter VIP home page Giter VIP logo

Comments (7)

achabdo avatar achabdo commented on September 26, 2024 1

I will go with the first option. Thank you.

from springwolf-core.

github-actions avatar github-actions commented on September 26, 2024

Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord.

from springwolf-core.

timonback avatar timonback commented on September 26, 2024

Hi @achabdo , true, the ui shows all functionality regardless of how Springwolf is configured.

To enable publishing, you have to explicitly activate the publishing setting in Springwolf (i.e. springwolf.plugin.kafka.publishing.enabled=true).

Just to clarify, you want to hide the publish button in the ui, when the publishing functionality is disabled in Springwolf?

from springwolf-core.

achabdo avatar achabdo commented on September 26, 2024

Hi @timonback ,yes , I want to hide the publish button when the publishing is disabled as users may think that they have the ability to send kafka notifications which can lead to confusion.

from springwolf-core.

timonback avatar timonback commented on September 26, 2024

Got it.

For this, Springwolf-ui would need to get the information from the backend. The backend would need to offer the information through some kind of new endpoint β€” combining the information from each activated plugin.
EDIT: an endpoint per plugin would be an alternative (for the short term)

I see also another solution, which is easy to implement and might be good enough. The button stays visible and when pressed, a better error message is shown (i.e.: publishing failed. This feature might have been disabled by the administrator of this application). Based on the http response status code, the authorization error can differentiated.

Is the second option good enough for you?
Feel free to get started on it.

from springwolf-core.

github-actions avatar github-actions commented on September 26, 2024

The change is staged for release and will be part of the next release.

If you want to try and verify it in your application today,
use the latest 1.X.0-SNAPSHOT build as described in our README.md > Testing SNAPSHOT version

Thank you for the report/contribution!

from springwolf-core.

github-actions avatar github-actions commented on September 26, 2024

The change is available in the latest release. πŸŽ‰

Thank you for the report/contribution and making Springwolf better!

from springwolf-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.