`use-fqn` overrides SpringDoc configuration about springwolf-core HOT 4 CLOSED

Thank you for the report and I agree with your expectation.

As part of the 1.0 release, I also slightly updated the code for handling the fqn setting.
Now, Springwolf always resets the swagger-core setting back to its original value:

We contributed the getter to swagger-core a while back in https://github.com/swagger-api/swagger-core/blame/3fcc473c33c56f306902853a451020926ad691ea/modules/swagger-core/src/main/java/io/swagger/v3/core/jackson/TypeNameResolver.java#L25
Unfortunately, it is a static field. So we set and reset it globally.

I wonder whether we are running into concurrency issues.

Is this also reproducible when the Springwolf init-mode is background?

from springwolf-core.

Hi @ctasada I had another look at it and stumbled on the configuration property springdoc.pre-loading-enabled. If it is set to true then then springdoc will create the spec asynchronously although they are only setting the value at the constructor level: https://github.com/springdoc/springdoc-openapi/blob/0fdfabadf9a51895ada8c432aa521715e971b149/springdoc-openapi-starter-common/src/main/java/org/springdoc/core/service/OpenAPIService.java#L210

If thats the case, there might be issues with multithreading.

We can have a deeper look if you could provide an example that reproduces the issue.

Edit:
After a second look, what you could do is to try and create a ModelResolver for springwolf where we can set the use-fqn flag independently from springdoc, something like:

    @Bean
    public ModelResolver modelResolver(ObjectMapper objectMapper) {
        final TypeNameResolver resolver = new TypeNameResolver() {};
        resolver.setUseFqn(false);
        return new ModelResolver(objectMapper,resolver );
    }

If it works, we could use that as a solution for springwolf.

from springwolf-core.

I tried the different approaches and the issue persists.

Applying the @Bean affects also both, SpringDocs and SpringWolf

from springwolf-core.

Closing because of inactivity. Please open a new issue if the problem persists.

from springwolf-core.