Instant preview is enabled on footnotes about mkdocs-material HOT 8 CLOSED

If you read #6704, you'll see that navigation.instant.preview predates the Markdown extension. Enabling this feature flag led to all internal links rendering previews. And no, the Markdown extension without any options should do exactly nothing, so that's an error we have to fix.

Anchor links to headers on the same page work fine for my website, so it doesn't really matter to me, but I also think if I had the option to disable that behavior I probably would.

We can check if we can add this as another option to the Markdown extension.

from mkdocs-material.

Thanks for reporting.

Ideally I'd like to enable material.extensions.preview on every page, but it looks bad when hovering over footnote links.

I strongly recommend not to do that. We'll also likely be removing the global feature flag again, as it was one of the earliest ideas of how instant previews could look, and we really should make them selective. Otherwise, too many links will get previews. We'll look into whether we can somehow "catch" instant previews adding a link to footnotes, but I recommend using our new Markdown extension. I'm curious, does this relate to #7040?

from mkdocs-material.

but I recommend using our new Markdown extension.

The automatic markdown extension is what I'm reporting the bug with though? Sorry if that wasn't clear. Your documentation says "you can use them on any internal link that points to a header on another page," but they are also being generated on internal links that point to footnotes, which is the whole problem.

Actually, I've otherwise been pretty happy with having them enabled globally, with the exception of a couple pages we added to sources.exclude.

from mkdocs-material.

Just to be perfectly clear, this report is not related to this setting (which I didn't know was a thing, but I might've been confusing with my use of the term "globally"):

theme:
  features:
    - navigation.instant.preview

from mkdocs-material.

Oops, sorry. I wasn't on my laptop and could only answer quickly, so I got stuck on:

Ideally I'd like to enable material.extensions.preview on every page, but it looks bad when hovering over footnote links.

Which I mixed up with navigation.instant.preview due to "every page" 🤦‍♂️ I agree that footnotes should definitely not be mounted, so we'll need to find a way to ensure that. I'm still not sure how to handle links to the same page. Previously, we excluded anchor links, but added them back because it was asked for, see #6704 (comment). Any thoughts?

from mkdocs-material.

I'm kind of confused now, because I seem to get the same behavior as navigation.instant.preview by simply enabling material.extensions.preview without any options (i.e. all internal links get previews, even without the data-preview attribute set). That is how the Markdown extension is supposed to work though right? I just don't get why both options to enable them globally exist.

Anchor links to headers on the same page work fine for my website, so it doesn't really matter to me, but I also think if I had the option to disable that behavior I probably would.

from mkdocs-material.

Fixed in 1f5fb72.

from mkdocs-material.

Released as part of 9.5.19+insiders-4.53.8.

from mkdocs-material.