src-code / flicks Goto Github PK

👍 nice work, especially attention to visual detail. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. We wanted you to explore the iOS framework without worrying too much about best practices yet, and I wouldn't expect you to have known about the issues below. You've probably already observed that the bulk of the code tends to go into view controllers. Many best practices of iOS are about how to move code out of view controllers for better encapsulation, maintainability, and testability. If this were a production app, here are a few notes after checking out the code:

• Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• Nice work with the header files and exposing few public properties. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
• In the detail view controller, your scroll view is only part of the screen. By convention, scroll views in this type of situation tends to be the full height of the screen.
• Nice work implementing the Movie model. It might be interesting to check out the Mantle project for a lightweight ORM.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers. You did this for the collection view, but not the table view.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at [email protected].