src-code / tweeter Goto Github PK

👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

• The model classes look good. I mentioned Mantle already for the Week 1 assignment as an example of another technique that some developers use for mapping JSON to models.
• NSDateFormatters are expensive to instantiate, so you can instantiate it once and use the same one, as long as you're using it from the same thread.
• Your public header files should expose a minimum interface. For example, in TweetListViewController.h, you shouldn't need to expose the tableView or refreshControl.
• In TweetTableViewCell.h, make sure to declare the delegate property as week, otherwise, you'll create a memory cycle and leak memory.
• In general, Auto Layout constraints look good. Generally, you shouldn't set a height constraint for labels, or it'll be too sensitive to the font. You can let the intrinsic content size drive the label height.
• Nice work handling the retweet label by dynamically modifying the constraint. Alternatively, you could have use a stack view to handle this case.
• You can move functions like getRelativeTimestamp to be a category method on NSDate.

Overall, the other classes look good.