Hello SS !

i need this script for merge it to San Andreas Playground Gamemode
but i don't think SQLite is good so i need it to be on INI or Mysql

but i don't have time (School DAMN !!) and i'm not good on Converting From SQLite to something

Please if u have a free time do u can convert it for me (in a Tree on Github ofc ) ? :)

Thanks
Yaa (Yassine)

• Split to Modules
• Normalise DataBase.
• Implement Streamer.
• Implement a checking feature while capturing a zone so that if the person started war left the zone wont make the conquering stop.
• Remove the limit of one gang war at a time.

Suggested by GameOvr
http://forum.sa-mp.com/showpost.php?p=4033540&postcount=153

The code base is really old and it's been 2 years since any major update has been done on this project.The code requires serious analysis and refactoring.

Hello SS

i can edit this script ?

i want to edit the commands and somethings
i will give u credits of course

Yassine

I Noticed Some Errors in the log while loading The FS
vv

any idea ._. ?

and some others errors when player join but stoped after he leave

http://pastebin.com/gZKaZKuq

C:\Users\Yassine\Desktop\SS-Gang-System-SQLITE-MySQL\SS_GANGSYSTEM.pwn(278) : error 035: argument type mismatch (argument 1)

:o check this ----> https://github.com/LVPYassine/SS-Gang-System-SQLITE/blob/master/SS_GANGSYSTEM.pwn#L278

https://github.com/LVPYassine/SS-Gang-System-SQLITE

i got 10 warnings ^^ after updating to MySQL

warning 213: tag mismatch

idk ._.

The scripter has to recompile the script every time they change the credentials for their database. To recompile the script, they also need all the includes. While a scripter is expected to have all these, it's not guaranteed.

The first possible solution that I can think of is the use of a .ini file that stores all this data. Any better ideas?

how to replace this db_next_row and mysql_retrieve_row to MySQL (R39) ???

there mysql_next_row on R6 / R7 But it's very old there any way to replace it with lastest ??

I mean are you serious?

I hope this one is valid :P
Anyway I'm going to make a pull request.

This is a list of mistakes, questionable or improvable code that I came across while updating the filterscript to MySQL:

PAWN

1. Gang data and user data are put into the same enum. While not wrong and absolutely fine, it's ambiguous and may cause confusion (this was especially the case for me) (see further references to this).

2. https://goo.gl/KDQhbF : _Zone is a non-descriptive name.

3. https://goo.gl/6JEqW2 : There's a for-loop and I can't figure out a logical reason for it. It has no body and does exactly what the do-while loop does.

4. https://goo.gl/zVHhqe (till line 305): zMinX, zMinY, zMaxX and zMaxY are defined as floats, but loaded in as integers.

5. https://goo.gl/dnyDzG : These values can be stored in a database. It brings more flexibility to the script as well as more predefined choices (what if the server wants them to be true upon starting the filterscript?).

6. https://goo.gl/fBMw0E : You're addressing ZInfo of which the first dimension is limited to MAX_GZONES, but you're using SS_Player to iterate through it. Shouldn't that be Zones?

7. (No specific line): You are oversizing quite a few string variables.

8. (No specific line): gangleader can only assume two values: 0 or 1. It would be more convenient if you declare it as a boolean variable and a tiny integer in the database (this is debatable since PAWN is a typeless language).

9. https://goo.gl/Yao89G: You are retrieving the player's name in OnPlayerText while you have it stored in a global variable.

10. (No specific line): You are creating new string variable under each flow control statement while it would be better to move the declaration to outside the statement and reuse it throughout the function. The naming would be a bit ambiguous, but it's a good habit (and possibly even more efficient).

SQL

1. The overall database structure seems odd to me. (PAWN N°1) (*)
2. The database lacks relations where they are useful.
1. An example of such is the members table. It has a column GangName, but I don't see the use for that. You can retrieve the gang's name, of which the player is a member, by running an extra SELECT query or reversing the SELECT query via a relationship (FK).

(*) A few alternatives to handle gamemode tables better:
- Create an include that handles logging in and registering (a callback OnPlayerLogin/OnPlayerRegister?)
- Assume the server doesn't have a players table and force data into it when the player spawns
- Lay restrictions to the server that it is loaded on:
- The server must restart after loading the filterscript
- The server must execute a few predefined commands to get it all working correctly

In case that you don't want to assume that the gamemode doesn't have a players table, then the best alternative would be to force the scripter to adjust a few defines in the filterscript.

I based all these points on assumptions. I assumed something while it might mean something else, so please, don't take this as absolute criticism. The conversion isn't completed yet by the time I submit this issue, so it doesn't include all the code that I thought needed a more detailed explanation. Notice that most of the points brought up can be found when scrolling through the first 200 lines.

Let us have an open discussion about what your intentions were/are at certain parts. They may not be as clear to me by just reading the code :)