srgssr / playsrg-apple Goto Github PK

After entering edit mode, we could immediately focus on the first element to be editable.

See https://srfmmz.atlassian.net/wiki/display/SRGPLAY/TEST-141+Play+iOS+Beta+8%3A+Exploratory+testing+-+A11y+SWI

Currently, artworks are not supported in control center and on the lock screen for downloaded content. This could be improved (probably with an appropriate Letterbox mechanism).

SWI supports only full-word search. We could improve the translation to better reflect this fact.

See https://srfmmz.atlassian.net/wiki/pages/viewpage.action?pageId=196646300

Our badge script is outdated. We should really use something simpler, like https://github.com/HazAT/badge which nicely integrates with Fastlane.

Topic lists are named "Latest reports" and "Most watched" on Android. Who is right?

We could save the last search string and restore it when the user opens the search again. Maybe this stored value should sometimes be cleared, though.

There are a log of issues with NSURLSession download resuming on recent iOS 9 and 10 versions (see http://stackoverflow.com/questions/39346231/resume-nsurlsession-on-ios10). We should investigate this issue further and create an Apple bug report.

In particular, resuming does not work correctly when the application is killed by the system to free up resources.

We could improve plural localizations using the native dedicated iOS mechanism.

Medias cannot be favorited from the player page if they have been downloaded first.

See https://srfmmz.atlassian.net/wiki/pages/viewpage.action?pageId=196646300

We now provide release notes information via MMF, and should therefore stop retrieving them from Pastebin.

We could use use a video recording solution for bug reporting. A possible solution would be ReplayKit. See artsy/eigen#2286 for an implementation suggestion.

Having the same image placeholder everywhere can be misleading. We might improve the situation by having different placeholders for different purposes.

When a media is being downloaded, enabling edit mode and selecting a media being downloaded makes the percentage label flickers.

As mentioned at the bottom of https://srfmmz.atlassian.net/wiki/display/SRGPLAY/TEST-139%3A+Play+iOS+Beta+7+-+Exploratory+testing, the user might not know precisely why the player seems stuck or why the app is taking a long time to load and is not frozen. We could display a status bar notification alerting the user when the connection is poor. This way, the situation would be clear in all cases described on the Confluence page (Edge, very bad network, 100% loss).

There are some noticeable hiccups on the homepage, when reloading data or dismissing the player with a gesture.

Consolidation work is probably taking some time. We could probably improve the situation by moving it to a background thread. Maybe SRGSSR/srgdataprovider-apple#7 could also provide an interesting answer (though in such cases extra care is required with all completion blocks).

Other possible performance improvements could probably be achieved with images (comment out image loading and measure performance difference to find the maximum performance gain) and asynchronous layout constructions, but they might require a lot of work.

Typeform has accessibility issues (see https://srfmmz.atlassian.net/wiki/display/SRGPLAY/Test-141+Play+iOS+Beta+8%3A+Exploratory+testing+-+A11y+SWI). We should report them so that they can improve their service.

The 1st launch user experience when no connection is available could be improved (redirecting the user to the download section, e.g.)

We never really discussed if and how we could / should measure playback of downloaded files. We should discuss this topic with the GD and perform changes as required.

Layouts (e.g. shows, calendar view, player view etc.) could be enhanced for landscape display, especially on iPad.

Especially on the go and with SBB networks, the player might not be able to resume, or might end with a bad state (especially if the stream was already opened once).

We could improve the situation. This probably involves changes in SRGMediaPlayer, SRGDataProvider and SRGLetterbox, but this remains to be investigated further.

On SBB networks, SSL certificate errors might happen as well. Redirect improvements made at the data provider level also seem not to work anymore.

Lydie has asked us to reduce the vertical spacing between titles and subtitles everywhere consistently.

To make it possible to reset the application without reinstalling it, we could provide a reset button in the system Settings.app. This option could also be made available in App Store releases.

Autolayout warnings are emitted at runtime. Some are probably related to Letterbox as well. Fix them.

When rotating the show list, a small glitch occurs with cells. This glitch does not appear on other views, it seems.

On iPhone 5C running iOS 9, some layouts are wrong or not optimal (e.g. player view, subtitle on two lines). Other issues can be seen when opening the player with another orientation as the presenting view controller.

These issues are probably minor and most of them should be fixed on iOS 10 and for more modern devices. Note that iPhones 5C will not be able to use iOS 11.

This is a side menu component bug. To reproduce:

1. Hold an iPad in landscape or portrait orientation
2. Open the search
3. Rotate the device
4. Close the search

The menu is then in an incorrect state and cannot be properly opened anymore.

The current calendar view is not good enough for VoiceOver access. Since we are based on FSCalendar, which itself is based on a collection, the VoiceOver focus always start at the beginning of the calendar. We currently restricted the date range to the last two months, but this is far from being optimal.

The FSCalendar user experience is cool, though. I think we should think about an alternative VoiceOver friendly implementation (maybe simply based on a standard date picker), enabled only when VoiceOver is active.

Some users are complaining that the font size is too large, and that they must scroll too much to browse content.

The default look & feel is probably good and readable. Moreover, scrolling is a cheap interaction on mobile, having to navigate is normal.

Still, I think we could provide a settings override in the app to choose another font size for Play. Those "power-users" would then be happier.

We also should optimize the cell sizes for smaller fonts, so that more content can be displayed.

We could have a look at those components to see whether they can be used to improve the user exprience:

https://github.com/EnderTan/ETNavBarTransparent
https://github.com/kingiol/KDInteractiveNavigationController
https://github.com/lkzhao/Hero

When scrolling through trending medias, it is difficult to manually stop so that the media thumbnail is not cut on the left or on the right.

UICollectionView provides a native snap mechanism to improve the user experience in such cases (without having use paging, which makes navigation slow).

Subtitles could span two lines for better readability if needed. Discuss with the design team.

Remark: Having https://github.com/SRGSSR/playsrg-ios/issues/22 implemented would certainly make such layouts easier.

The radio homepage header section titles don't match (e.g. Derniers audios vs. Dernières émissions and Les dernières 24 heures vs. Derniers audios). Align both platforms according to what media lists represent.

Similarly, on the TV homepage, the live section header titles are not aligned (e.g. Jetzt auf SRF vs. Jetzt im TV).

For livestreams, the channel logo must be displayed on player views, see attached screenshot.

Accessibility could be even further improved by:

• Having all dates and times properly spelled out
• ... and also when navigating the calendar
• Focusing again on the selected cell when navigating back

Currently, search on Android sends one view event, and iOS sends one such event for each change of the search criterium.

We should probably send only relevant search results, and as hidden events (not as view events).

Currently, seeking from the headset remote control settings (not using the skip buttons usually available from the control center) seeks in fix increments. We could implement smarter seeks (like Apple does) which start with small increments but, as the headset button is held, increase to larger values.

After some thoughts, it appears that the HomeSectionInfo concept should stay close to the home (as its name suggests). As it is used currently, sometimes outside the home view controller, the concept becomes difficult to understand. For example, the HomeMediasViewController concept blurs the lines and should only display media lists for a set of supported requests, and should be appropriately renamed to make the confusing Home word disappear.

An enum could be introduced for the set of requests supported by this media list view controller, close but not merging the values of the HomeSection and TopicSection enums into a single enumeration (e.g. MediaList or something similar).

The constructor of the renamed HomeMediasViewController should then mostly expect a value from this enumeration, and branch to the appropriate request. The page type used for statistics must be internally matched, probably through a dictionary mapping the MediaList values to the corresponding page type.

To provide easier customization of cell layouts (especially depending on the layout traits), we could have all cell layouts be UIStackView-based.

The SRG font has been updated. This issue could be best fixed with a design framework (see SRGSSR/srgletterbox-apple#11)

When toggling full screen on the audio player, the live access button bar seems to come emerge from the view center.

iOS and Android don't have the same menu order. Discuss and maybe align.

See https://srfmmz.atlassian.net/wiki/pages/viewpage.action?pageId=196646300

Stack views do not align items on integer pixels, leading to this issue.

In the regional selection sheet, SRF suggested we could display which item is currently being selected.

For radio SRF 1, the navigation bar tint color is black. When navigating the application (e.g. accessing the most heard media list), the tint color stays correct on all screens. But if a modal is displayed, the back button tint color will be white when navigating again on another screen.

This is probably an iOS bug (other strange tint color behaviors have been reported after modal presentation).

We could save and restore the previous search criterium entered by the user.

As discussed during TagCommander workshops, we will remove localization from page levels and titles (if not media titles, of course) to have comparable measurements across all BUs, see https://srfmmz.atlassian.net/wiki/spaces/INTFORSCHUNG/pages/197019081.

This will happen after complete TagCommander transition. Until comScore is dropped, we namely need to keep the same localized names to get comparable results. When the transition is complete:

• Remove code localizing the levels and titles.
• Remove associated useless translations on Crowdin.

Currently, a collection view layout issue generates several crashes in production (see e.g. https://rink.hockeyapp.net/manage/apps/105349/app_versions/27/crash_reasons/178105995).

Whichever the BU, the crash always involves 262 items in the collection. In fact, this corresponds to the number of weeks during the last 5 years (can slightly vary). This is therefore an FSCalendarcrash, probably related to the fact we have set a maximum date, see WenchaoD/FSCalendar#565.

On some devices (e.g. iPad Mini), scrolling performance is not optimal, especially on the home page. We could maybe investigate the cost of solutions like FastImageCache and whether they can improve the situation.

Some summaries and related contents apparently contain HTML (please add examples if you find any). We should support proper HTML display accordingly.