Comments (19)
I just noticed there is an open PR for that new event type so it'll hopefully get merged soon.
from labeler.
It's been merged, I'll wait for a release and upgrade.
from labeler.
Hi @kbendick I haven't seen a release including that PR yet. What we can do is try to bump the go-github version and use the current master so we can see that event before they publish a final release. I can try this this week, but do feel free to send a PR!
from labeler.
Thanks for the heads up @akinsolb I'll take a look
from labeler.
Thank you, @jhlegarreta - it looks like we haven't implemented support for that webhook event. I've opened a new issue to support it: google/go-github#1834
from labeler.
For the records, following the above comment we tested the branch in another repository and the action labeled the issue
Besides, the action creates the corresponding label if it does not exist when a match is found in the configuration file.
Thnx @srvaroa
from labeler.
Hi, thanks for trying it out. It depends on the go-github library supporting that event. On a quick inspection it looks like the latest version doesn't support it yet (https://github.com/google/go-github/blob/159b448168db1fc1bc61a556e6280e12dfc00a6d/github/messages.go#L43). If you can make a feature request there I'm able to integrate it fairly quickly once it's available.
I may be able to implement it myself but can't promise it'll be too fast.
from labeler.
Hi @srvaroa, has this been fixed? The pull_request_target
is important for repos where people fork and submit PRs but don't necessarily have write access. For example, many of the Apache repos. The example github labeler action doesn't support the features that we need for the Apache Spark repo.
If this has been merged, can you cut a release or let me know which release version needs to be used so that pull_request_target
is supported?
from labeler.
@srvaroa Think this might be out in a release now
from labeler.
@srvaroa folks at goolge said that the feature in the PR mentioned in #13 (comment) will cut into a release within the next few hours/maybe a day or two.
Now, inspecting the webhook event mapping you pointed, that PR does not include the pull_request_target
event. So I'm wondering whether the mentioned PR does in reality contain what is necessary to support pull_request_target
events in your PR labeler action or else the mapping would still be missing. Looking forward to the feature. Thanks.
from labeler.
go-github
now provides support for pull_request_targert
events
@srvaroa provided that they tag a new version (they do that on demand), do you think that is enough to support them in the labeler
actions/would have the time to implement it? Maybe an attempt on the go-github
might cast light on whether something is still missing on that end? Thanks.
from labeler.
Hi, sorry I missed replying here. A release from their side would help to try and implement this case here. I can probably put a bit of time to try and get it working (of course, very happy if someone else wants to take a stab at it).
from labeler.
So a tagged release of go-github
would be useful here? If so, I can start working on one.
from labeler.
yup, thanks!
from labeler.
Wonderful both @srvaroa and @gmlewis
from labeler.
I finally got an LGTM, so https://github.com/google/go-github/releases/tag/v35.0.0 has now been released.
from labeler.
Wonderful @gmlewis. Thanks !
@srvaroa any progress on this would be much appreciated !
from labeler.
Hi, thanks @gmlewis and @jhlegarreta, I've just submitted a PR that should make this work. I can't test it more thoroughly now but if you can try it out (using srvaroa/[email protected]
) it'd be appreciated. A sample payload that I can add to a test would also help.
PR: #27
Cheers,
from labeler.
Thanks for the effort @srvaroa
Unfortunately, it looks like the first attempt was unsuccessful here:
https://github.com/InsightSoftwareConsortium/ITK/runs/2427975641?check_suite_focus=true#step:3:78
But that's because the workflow is still attempting to use the master
branch:
https://github.com/InsightSoftwareConsortium/ITK/runs/2427975641?check_suite_focus=true#step:3:1
And I fear that unless I merge the PR, we will not know if the changes in #27 work for the target use case. I'd like to avoid doing various merge and revert cycles or tests on that repository for many reasons
Maybe your or I can open a test repository that includes an action that uses your labeler, and the other one can try submitting a PR to see if pull_request_target
-like events are working off the branch in #27?
from labeler.
Related Issues (20)
- Not work `files` condition
- Avoid creating labels when the labeler matches patterns in the config file HOT 3
- Support negative conditions HOT 4
- add condition for draft pull requests HOT 2
- Can include/exclude regex patterns be handled? HOT 3
- Support for GitHub Enterprise Server HOT 3
- Doesn't work with submodules HOT 2
- Support for regex on description
- Feature request: New condition based on whether the PR author has merge permissions on the target HOT 3
- Option to append to existing Labels HOT 7
- Dockerbuild is failing when running the action HOT 4
- Negative lookahead is not supported HOT 6
- Some regex not working in filter via property HOT 4
- Build fails due to missing imports `gopkg.in/check.v1` & `gopkg.in/yaml.v2` HOT 3
- Docker build failed HOT 4
- Add support for issues HOT 5
- [Feature] Naming labels based on regex capture groups HOT 1
- Ignore files in PR Size condition HOT 3
- Semantic versioning HOT 5
- [Feature] support local config file HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from labeler.