srwalter / dbus-bytestream Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 4.0 1.15 MB

Native D-Bus implementation for Rust

License: GNU Lesser General Public License v2.1

Rust 99.33% Shell 0.67%

dbus-bytestream's People

Contributors

Stargazers

Watchers

Forkers

tylerwhall mathstuf marcelbuesing albel727

dbus-bytestream's Issues

Hook into an event loop

It'd be nice to be able to hook into an event loop rather than having to rely on a blocking call to read messages.

Plans for service-side APIs?

It appears this is only for communicating over D-Bus, not for setting up a service on the bus.

Related, any plans for converting from an XML description to a Rust skeleton (c.f., qdbusxml2cpp from Qt)?

New release?

Could a new release be tagged? I'd like to be able to upload some crates which require the PRs I've filed. Thanks.

Demarshaling messages with zero-length arrays fails

When a message signature contains an array, but the message body actually contains no elements, parsing incorrectly fails with DemarshalError::MismatchedParens, due to invalid handling in

dbus-bytestream/src/demarshal.rs

Lines 185 to 195 in f7f7d1c

 let mut sig_copy = "".to_owned(); 

 while *offset < start_offset+(array_len as usize) { 

 // We want to pass the same signature to each call of demarshal 

 sig_copy = sig.to_owned(); 

 vec.push(try!(demarshal(buf, offset, &mut sig_copy))); 

 } 

 // Now that we're done with our elements we can forget the elements consumed by demarshal 

 let mut mysig = sig.clone(); 

 mysig.truncate(sig.len() - sig_copy.len()); 

 mysig.insert(0, 'a'); 

 *sig = sig_copy;

Note that if the while loop doesn't execute even once, sig_copy will remain empty, and the currently parsed sig will be unconditionally emptied, instead of being set to fields remaining to be parsed.

Maybe I'll fix the bug myself later and publish a PR, but meanwhile here's an example failing test case with an array in the middle of a simple struct. Both nonempty and empty array tests are added for contrast.

albel727@460d6c1

Relicense e.g. under MPL

It's great to see a native Rust dbus protocol implementation and I would like to somehow use this as a backend for a Rust native alternative to dbus-codgen or an alternative to dbus-tokio aka dbus-bytestream-tokio. Given the LGPL license I feel though it might be quite hard to use this in anything other than LGPL or GPL code since the library is by default linked statically. Don't get me wrong I entirely get the changes / fixes etc. should be upstreamed part and support that. Would you mind considering e.g. MPL, MIT or Apache ... ?

srwalter / dbus-bytestream Goto Github PK

dbus-bytestream's People

Contributors

Stargazers

Watchers

Forkers

dbus-bytestream's Issues

Hook into an event loop

Plans for service-side APIs?

New release?

Demarshaling messages with zero-length arrays fails

Relicense e.g. under MPL

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let mut sig_copy = "".to_owned();
	while *offset < start_offset+(array_len as usize) {
	// We want to pass the same signature to each call of demarshal
	sig_copy = sig.to_owned();
	vec.push(try!(demarshal(buf, offset, &mut sig_copy)));
	}
	// Now that we're done with our elements we can forget the elements consumed by demarshal
	let mut mysig = sig.clone();
	mysig.truncate(sig.len() - sig_copy.len());
	mysig.insert(0, 'a');
	*sig = sig_copy;