sshnet / integrationtests Goto Github PK

KeyboardInteractive_PasswordExpired fails on my container with:

Assert.AreEqual failed. Expected:<0>. Actual:<1>. passwd: unrecognized option: expire
BusyBox v1.34.1 (2021-11-23 00:57:35 UTC) multi-call binary.

Usage: passwd [-a ALG] [-dlu] [USER]

Change USER's password (default: current user)

	-a ALG	des,md5,sha256/512 (default sha512)
	-d	Set password to ''
	-l	Lock (disable) account
	-u	Unlock (enable) account

Additionally, this leaves the sshuser with a random password. To avoid this, we should:

• reset the password in the TestInitialize phase
• reset the password in catch block in KeyboardInteractive_PasswordExpired
  I think this way regardless if the tests are interrupted we will return to the defined state.

I can try to fix this if you want?

MemoryStream.ctor(byte[]) would reuse the buffer.

The Expect() is called without a timeout, causing the test to hang if Expect is not satisfied.

If your system has UAC enabled and you run VS normal/unelevated, the DisableHostNetworkConnection calls fail with:

System.ApplicationException: Failed to disable 'Ethernet 2' network connection. Return value is 5.
Make sure you're running the tests with elevated priviliges.

Could we mark tests as inconclusive instead of failing them in this case?
DisableHostNetworkConnection could use new Win32Exception(retValue), this would provide better error information.