Giter VIP home page Giter VIP logo

Comments (6)

sstur avatar sstur commented on July 17, 2024

Hey @just-another-jxliu, thanks for reporting this!

I'm going to roll back the latest release until we get this solved.

@msglifeIberia and or @MSGInsurIt, would you be interested in revisiting PR #254 to see if we could make it work with Safari?

from draft-js-utils.

sstur avatar sstur commented on July 17, 2024

For context, the issue is that the RegEx above uses a Negative lookbehind assertion which is the (?<! part. Safari doesn't support this.

Here's a minimum reproducible test case:

let regEx = /(?<!y)x/

image

from draft-js-utils.

MSGInsurIt avatar MSGInsurIt commented on July 17, 2024

Hi,

We are not finding a quick solution for this issue without Negative lookbehind support without doing considerable code changes. For now, we would like to propose keeping the fix for the browsers that support it and having a fallback mechanism for those that don't support.

from draft-js-utils.

MSGInsurIt avatar MSGInsurIt commented on July 17, 2024

FYI @just-another-jxliu ,
The solution might also come from the browser.
https://bugs.webkit.org/show_bug.cgi?id=174931

from draft-js-utils.

MSGInsurIt avatar MSGInsurIt commented on July 17, 2024

Hi @sstur,

The issue with the RegExp lookbehind assertions was finally implemented in the safari browser as mentioned in the following link: https://bugs.webkit.org/show_bug.cgi?id=174931

It would make sense to re-apply the merge #254 to the latest version.

Will you merge the code again?

from draft-js-utils.

MSGInsurIt avatar MSGInsurIt commented on July 17, 2024

Negative lookbehind assertion It's working now in Release 161 of Safari Technology Preview, downloads are here: [https://developer.apple.com/safari/resources/]

Although it didn't make the cut for the release notes!

from draft-js-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.