Comments (8)
@sstur could you please add me as a contributor to the repo? I'll create a PR to fix the issue.
from draft-js-utils.
Hey @yuxin1234, thanks for offering to help. I believe you can make a PR without any special access, let me know if you run into any issues.
BTW, I think this issue was caused by #254, so feel free to make a PR to revert that, or if you have a solution that preserves the italic fix, even better. Thanks!
from draft-js-utils.
Note: this issue was previously being tracked in #255.
from draft-js-utils.
@sstur Thanks. I have a fix that preserves the italic fix. I got this error when I did git push.
git push --set-upstream origin fixSafariDisplay
remote: Permission to sstur/draft-js-utils.git denied to yuxin1234.
fatal: unable to access 'https://github.com/sstur/draft-js-utils.git/': The requested URL returned error: 403
Please help. Thank you.
from draft-js-utils.
Right. When making a PR to a public/open-source repo you'll need to fork it first.
from draft-js-utils.
More details here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
from draft-js-utils.
@sstur Thanks. My first time contributing to a public repo. Will follow the instructions.
from draft-js-utils.
@sstur Please review #261. Thank you.
from draft-js-utils.
Related Issues (20)
- Example for markup code-block export
- inLineStyles are not getting converted or they are ignored HOT 5
- Publish draft-js-export-markdown HOT 1
- export-html BlockRenderer doesn't work properly with list
- Error: 'OrderedSet' is not exported by node_modules\immutable\dist\immutable.js, imported by node_modules\draft-js-utils\esm\getEntityRanges.js
- Render custom inline + block React components
- stateFromMarkdown() adds code inline style inside code block
- A way to add CSS classes to HTML tags
- Markdown Italic does not work with word selected in middle HOT 1
- Code Highlighting inside blockRenderers
- target=" _blank" converting to target = "_self" on using stateFromHTML
- Update to italic parsing breaks Safari 15.5 HOT 6
- stateToHTML creates nested html based on the order the options are defined and not chronologically.
- Why to keep "\n" in html string ? HOT 1
- Custom wrapper elements
- Regex not supported in Safari
- could you please update immutable to verion 4.1.0? HOT 2
- How to use draft-js-import-markdown with TypeScript?
- draft-js-import-html Not recognize Iframe as a state
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from draft-js-utils.