Giter VIP home page Giter VIP logo

Comments (8)

yuxin1234 avatar yuxin1234 commented on July 17, 2024

@sstur could you please add me as a contributor to the repo? I'll create a PR to fix the issue.

from draft-js-utils.

sstur avatar sstur commented on July 17, 2024

Hey @yuxin1234, thanks for offering to help. I believe you can make a PR without any special access, let me know if you run into any issues.

BTW, I think this issue was caused by #254, so feel free to make a PR to revert that, or if you have a solution that preserves the italic fix, even better. Thanks!

from draft-js-utils.

sstur avatar sstur commented on July 17, 2024

Note: this issue was previously being tracked in #255.

from draft-js-utils.

yuxin1234 avatar yuxin1234 commented on July 17, 2024

@sstur Thanks. I have a fix that preserves the italic fix. I got this error when I did git push.
git push --set-upstream origin fixSafariDisplay
remote: Permission to sstur/draft-js-utils.git denied to yuxin1234.
fatal: unable to access 'https://github.com/sstur/draft-js-utils.git/': The requested URL returned error: 403
Please help. Thank you.

from draft-js-utils.

sstur avatar sstur commented on July 17, 2024

Right. When making a PR to a public/open-source repo you'll need to fork it first.

from draft-js-utils.

sstur avatar sstur commented on July 17, 2024

More details here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

from draft-js-utils.

yuxin1234 avatar yuxin1234 commented on July 17, 2024

@sstur Thanks. My first time contributing to a public repo. Will follow the instructions.

from draft-js-utils.

yuxin1234 avatar yuxin1234 commented on July 17, 2024

@sstur Please review #261. Thank you.

from draft-js-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.