Third road swirls on lefthand drive roads about cs-parallelroadtool HOT 12 CLOSED

I need to investigate this.
I admit I never tested left-hand drive with more than 2 roads, so I may have missed something.

from cs-parallelroadtool.

Noticed in my tests that swirling happens wwith every other additional road, ie 2nd, 4th, 6th etc.
Have found a preliminary fix to eliminate swirling but it rose an issue with snapping :(
Still investigating...

from cs-parallelroadtool.

Tracking it in ISSUE-38-2 branch.

from cs-parallelroadtool.

@BadiBasso I forgot to link the branch, but I started working on this yesterday and got to your very same situation. Node position is now correct, but it doesn't snap.

If you need it, here's a quick log snippet that highlights the issue:

[Parallel Road Tool 1.0.2] [CreateSegment] [START] Using old node from previous iteration 24478 instead of the given one 23377
[Parallel Road Tool 1.0.2] [CreateSegment] [START] Start node (354.8, 226.0, -470.1) becomes (339.3, 226.0, -473.9)
[Parallel Road Tool 1.0.2] [CreateSegment] [END] (335.9, 226.1, -392.4) --> (320.3, 226.1, -396.1) | isEnteringSlope = False | invert = False | isSlope = False

[Parallel Road Tool 1.0.2] [CreateSegment] [START] (354.8, 226.0, -470.1) --> (323.7, 226.0, -477.7) | isLeftHand = True | invert = True | isSlope = False | startNode = 25198 | endNode = 23377
[Parallel Road Tool 1.0.2] [CreateSegment] [END] (335.9, 226.1, -392.4) --> (304.8, 226.1, -399.9) | isEnteringSlope = False | invert = True | isSlope = False

[Parallel Road Tool 1.0.2] [CreateSegment] [START] Using old node from previous iteration 17757 instead of the given one 23377
[Parallel Road Tool 1.0.2] [CreateSegment] [START] Start node (354.8, 226.0, -470.1) becomes (308.2, 226.0, -481.4)
[Parallel Road Tool 1.0.2] [CreateSegment] [END] (335.9, 226.1, -392.4) --> (289.2, 226.1, -403.7) | isEnteringSlope = False | invert = False | isSlope = False

[Parallel Road Tool 1.0.2] [CreateSegment] [START] (354.8, 226.0, -470.1) --> (292.6, 226.0, -485.2) | isLeftHand = True | invert = True | isSlope = False | startNode = 25198 | endNode = 23377
[Parallel Road Tool 1.0.2] [CreateSegment] [END] (335.9, 226.1, -392.4) --> (273.7, 226.1, -407.5) | isEnteringSlope = False | invert = True | isSlope = False

The key should be invert = True because it works when invert = False.

from cs-parallelroadtool.

@BadiBasso just pushed again to fix it. I don't like the fix tho, I feel like I'm missing what really happens with the invert parameter when in left-hand drive.

from cs-parallelroadtool.

Ok, no, situation is even worse than what I thought. Reversing roads and curves are not working anymore. This will take a little bit than what I expected.

EDIT: reversing roads should be fine now, let's see what happens with curves.

from cs-parallelroadtool.

I think I got it...
Have tested with one ways and highways. Everything seems to be nice :)

Will place a PR after cleaning up….

from cs-parallelroadtool.

@rsb10961 can you please switch to the BETA version and report back to see if it has been fixed for you? Thanks.

from cs-parallelroadtool.

Looks good to me guys!

from cs-parallelroadtool.

Looks promising! Could you please try with more roads (4 or more) mixed with oneways and/or highways?
Just to verify that nodes connect correctly.
BTW additional roads are placed on right side in left hand drive now when offset is positive. More logical IMO. What do you think?

from cs-parallelroadtool.

Yep, the nodes do connect correctly, as far as I can make out.

from cs-parallelroadtool.

Great! Thanks for your help!

from cs-parallelroadtool.