staceybellerose / randomwordgenerator Goto Github PK

I've selected MainActivity.onCreate(Bundle) for refactoring, which is a unit of 35 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected ReservoirSampler.weightedSample(int,InputStream,int,int) for refactoring, which is a unit of 34 lines of code and 4 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of parameters per unit to at most 4.
• Why❓
  Keeping the number of parameters low makes units easier to understand, test and reuse.
• How 🔧
  Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

Current Behavior: Two column display toggled off / on keeps the words in two columns.

Expected Behavior: Toggling the setting should display the words in one or two columns

I've selected ReservoirSampler.weightedSample(int,InputStream,int,int) for refactoring, which is a unit of 34 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

CodeFactor found an issue: Duplication of key "env" in mapping

It's currently on:
.travis.yml:25

I've selected PRNGFixes.installLinuxPRNGSecureRandom() for refactoring, which is a unit of 32 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

The spinner does not go away when displaying the main page if the user chooses two column display and an odd number of items.

I've selected ReservoirSampler.unweightedSample(int,InputStream,int,int) for refactoring, which is a unit of 29 lines of code and 4 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of parameters per unit to at most 4.
• Why❓
  Keeping the number of parameters low makes units easier to understand, test and reuse.
• How 🔧
  Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

In onActivityResult when returning from Settings, read the shared preferences and set fields based on the results, so that they don't have to be read in multiple methods, and passed as parameters.

I've selected MainActivity.readWordList(int,int,int) for refactoring, which is a unit of 25 lines of code and 3 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

While refactoring this method, also refactor getWordLengths(), which should set fields, not return an array.

Here's the gist of this guideline:

• Definition 📖
  Limit the number of parameters per unit to at most 4.
• Why❓
  Keeping the number of parameters low makes units easier to understand, test and reuse.
• How 🔧
  Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected ReservoirSampler.sample(int,InputStream,boolean,int,int) for refactoring, which is a unit of 7 lines of code and 5 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the number of parameters per unit to at most 4.
• Why❓
  Keeping the number of parameters low makes units easier to understand, test and reuse.
• How 🔧
  Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

CodeFactor found an issue: The input method in Python 2 will read from standard input, evaluate and run the resulting string as python source code. This is similar, though in many ways worse, then using eval. On Python 2, use raw_input instead, input is safe in Python 3.

It's currently on:
scripts\wiki\check_wiki_corpus.py:18

CodeFactor found an issue: Redefining built-in 'input'

It's currently on:
scripts\nltk\process_nltk_corpus.py:14